apply discrete cmap when needed #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geospatial-jeff
approved these changes
Dec 22, 2020
kylebarron
reviewed
Dec 23, 2020
| @@ -94,6 +94,9 @@ def apply_cmap( | |||
| if data.shape[0] > 1: | |||
| raise InvalidFormat("Source data must be 1 band") | |||
|
|
|||
| if len(colormap) > 256 or max(colormap) > 256: | |||
There was a problem hiding this comment.
Why do you only check for > 256 and not != 256?
There was a problem hiding this comment.
@kylebarron because make_lut should work for cmap that have less than 256 value or a max smaller than 256
https://github.com/cogeotiff/rio-tiler/pull/325/files#diff-1c0d3ee98487c3ad9e96a708cf2b17d8dba80980c2b0bd6faaca3688543bfd41R66-R68
just realizing that it should be max(colormap) >= 256 🤦
e.g
cmap = {1: [255,255,255,255], 255: [1,1,1, 255]}
make_lut(cmap)
array([[ 0, 0, 0, 0],
[255, 255, 255, 255],
[ 0, 0, 0, 0],
...,
[ 0, 0, 0, 0],
[ 0, 0, 0, 0],
[ 1, 1, 1, 255]], dtype=uint8)
There was a problem hiding this comment.
updated the code with comments: https://github.com/cogeotiff/rio-tiler/blob/master/rio_tiler/colormap.py#L97-L101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #321