Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automatically apply discrete colormap when cmap doesn't have 256 values #321

Closed
vincentsarago opened this issue Dec 21, 2020 · 0 comments · Fixed by #325
Closed

automatically apply discrete colormap when cmap doesn't have 256 values #321

vincentsarago opened this issue Dec 21, 2020 · 0 comments · Fixed by #325
Assignees
@vincentsarago
Labels
enhancement

Comments

@vincentsarago
Copy link
Member

vincentsarago commented Dec 21, 2020 •
edited
Loading

When a user has a custom colormap which is not a 256 dict (for 0 to 256) we should automatically switch to apply_discrete_cmap because

  • make_lut won't work with dict which doesn't have 256 values
  • we don't want to make a LUT with more than 256 value (e.g if a cmap is like {0: [...], 1000:[...]} a lut would be really large, while we could use apply_discrete_cmap directly.

rio-tiler/rio_tiler/colormap.py

Line 97 in 79da537

lookup_table = make_lut(colormap)

This is to support developmentseed/titiler#153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincentsarago vincentsarago

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

apply discrete cmap when needed cogeotiff/rio-tiler
1 participant
@vincentsarago