Misc fixes for core from the cogent lab development branch and removal of all lab stuff. #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bad aspect of WGSL..
… and does the assignment for writable vars.
…fset in tensor.Shape to support encoding the strides in the first NumDims dimensions of a tensor.
… space b/c everything is generated.
… functions. also return *Float64 directly as that makes more sense -- goal wraps in generic tensor automatically but ops should return the most specific value possible to facilitate further opts.
… nogui; fixes for tensor, table io to not use core.Filename; finally don't have gui mode activated for goal command.
…e colors such files with distincitve blue-grey color. Fixes #1238 Also finally fixed dark / light mode switching for texteditor highlighting -- uses distinct generated theme colors instead of changing the original color, which remains intact.
…ead only; does NOT set the buffer read only status based on styling (only effect of buffer is undo -- need that for output buffers that don't need to be recording undos).
…e and ideal targets.
…differences from integer values.
kkoreilly
requested changes
Dec 23, 2024
kkoreilly
requested changes
Dec 23, 2024
|
sticky hover on tree definitely caused by switch from Actual -> Alloc in the bbox computation. trying to fix -- will pick up again in am. don't hold up merging for that -- can definitely will do a separate PR on that! |
…t to have the same name as generated files
|
For future reference, we are bailing on Alloc to Actual change here since it causes the tree sticky hovering, so that will just happen in #1389. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verified that everything in lab is working with this branch.
*From @kkoreilly: this is built on #1229, except with goal, tensor, plot, etc removed given that they are now in Cogent Lab (that removal is the main cause of the large number of line deletions).
See https://github.com/emer/etensor for a copy of the old tensor and plot functionality.*