Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto resize search bar #590

Merged
merged 3 commits into from
Dec 24, 2024
Merged

feat: auto resize search bar #590

merged 3 commits into from
Dec 24, 2024

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Dec 21, 2024

fix #281

As per requirements from the issue description, I have used TextAreaAutoResize component from Material UI. I have also adjusted the styles of the textarea since the text inside is overlapping with search icon button.

Before:
image

After:
image

I noticed pressing enter key on the current site https://cofacts.org/search did not trigger search, but I have added it as per the issue description.

I also adjusted the Searching text to stick at the top of the flex area.

Copy link
Member

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I have raised a UX-related question

components/SearchPageJumbotron.js Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 71.733%. remained the same
when pulling b945378 on ydcjeff:issue-281
into d5a4be4 on cofacts:master.

@MrOrz MrOrz merged commit 7116883 into cofacts:master Dec 24, 2024
2 checks passed
@ydcjeff ydcjeff deleted the issue-281 branch December 24, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search bar input should span multiple rows
3 participants