Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar input should span multiple rows #281

Closed
MrOrz opened this issue Jul 11, 2020 · 1 comment · Fixed by #590
Closed

Search bar input should span multiple rows #281

MrOrz opened this issue Jul 11, 2020 · 1 comment · Fixed by #590

Comments

@MrOrz
Copy link
Member

MrOrz commented Jul 11, 2020

As-is

The search input in search page is only 1 line high
search

To-be

As in spec, the search input should grow as input.

image

This should be achievable using Material UI's Textarea autosize.

@MrOrz
Copy link
Member Author

MrOrz commented Jul 22, 2020

From discussions in https://g0v.hackmd.io/OC7BneJ3TEGJHge1hWV-0w?both#%E6%9C%AA%E7%AB%9F%E9%A0%85%E7%9B%AE
even though we can support multi-line, "enter" should still trigger search instead of new lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant