-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mbedtls library version to 3.5.1 #123
Commits on Jan 4, 2024
-
Update mbedtls version to 3.5.1.
Tests are passing locally. Additionally, we no longer skip the tls tests. Let's see how CI likes it.
Cody Piersall committedJan 4, 2024 Configuration menu - View commit details
-
Copy full SHA for 104c0b6 - Browse repository at this point
Copy the full SHA 104c0b6View commit details
Commits on Jan 6, 2024
-
Hmmm, seems like mbedtls v2.28.6 works...
v3.5.1 is failing to build wheels due to libraries getting installed to lib64 instead of lib on cibuildwheel.
Cody Piersall committedJan 6, 2024 Configuration menu - View commit details
-
Copy full SHA for 6d2f649 - Browse repository at this point
Copy the full SHA 6d2f649View commit details -
Seems like mbedtls v3.1.0 works.
Cody Piersall committedJan 6, 2024 Configuration menu - View commit details
-
Copy full SHA for 78adb61 - Browse repository at this point
Copy the full SHA 78adb61View commit details
Commits on Jan 8, 2024
-
Fix some class/instance variable confusion.
Cody Piersall committedJan 8, 2024 Configuration menu - View commit details
-
Copy full SHA for 9b80c6f - Browse repository at this point
Copy the full SHA 9b80c6fView commit details -
Still had some accidental class/instance variable confusion.
Cody Piersall committedJan 8, 2024 Configuration menu - View commit details
-
Copy full SHA for 568b66d - Browse repository at this point
Copy the full SHA 568b66dView commit details
Commits on Jan 10, 2024
-
Get v3.5.1 to build in docker image.
Seems like the root cause is that when mbedtls moved to use GnuInstallDirs, the install directory for the library changed. Which makes sense. I couldn't figure out how to get mbedtls to install do lib, so I just check if lib64 exists, and if so move to lib. Doesn't feel good, but there it is.
Cody Piersall committedJan 10, 2024 Configuration menu - View commit details
-
Copy full SHA for 2a391cb - Browse repository at this point
Copy the full SHA 2a391cbView commit details
Commits on Jan 11, 2024
-
moving the lib64 to lib unconditionally causes the build to fail when the 2nd wheel is getting built, because then the destination directory exists. We also moved to copying instead of moving, because that will prevent the mbedtls lib from doing extra work when it finds out that its targets are missing.
Cody Piersall committedJan 11, 2024 Configuration menu - View commit details
-
Copy full SHA for 633577a - Browse repository at this point
Copy the full SHA 633577aView commit details -
Hopefully this works in CI, or at least works a little better.
Cody Piersall committedJan 11, 2024 Configuration menu - View commit details
-
Copy full SHA for 11b2881 - Browse repository at this point
Copy the full SHA 11b2881View commit details
Commits on Jan 15, 2024
-
Fix i686 Linux build failures.
mbedtls fails to build on 32-bit Linux without passing some compiler options. We pass them through an environment variable, which is not the best way to do it, but here we are. Hopefully this will be able to be removed whenever mbedtls pushes a new release; seems that this has been fixed upstream in merge Mbed-TLS/mbedtls#8406.
Cody Piersall committedJan 15, 2024 Configuration menu - View commit details
-
Copy full SHA for 543bb6b - Browse repository at this point
Copy the full SHA 543bb6bView commit details