Update mbedtls library version to 3.5.1 #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
January 3, 2024 21:14
Tests are passing locally. Additionally, we no longer skip the tls tests. Let's see how CI likes it.
v3.5.1 is failing to build wheels due to libraries getting installed to lib64 instead of lib on cibuildwheel.
Seems like the root cause is that when mbedtls moved to use GnuInstallDirs, the install directory for the library changed. Which makes sense. I couldn't figure out how to get mbedtls to install do lib, so I just check if lib64 exists, and if so move to lib. Doesn't feel good, but there it is.
moving the lib64 to lib unconditionally causes the build to fail when the 2nd wheel is getting built, because then the destination directory exists. We also moved to copying instead of moving, because that will prevent the mbedtls lib from doing extra work when it finds out that its targets are missing.
Hopefully this works in CI, or at least works a little better.
mbedtls fails to build on 32-bit Linux without passing some compiler options. We pass them through an environment variable, which is not the best way to do it, but here we are. Hopefully this will be able to be removed whenever mbedtls pushes a new release; seems that this has been fixed upstream in merge Mbed-TLS/mbedtls#8406.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep crypto dependencies up to date.