Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update e2e tests for newer changes in site #1085

Merged
merged 2 commits into from
Oct 8, 2024
Merged

fix: update e2e tests for newer changes in site #1085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c62d9c
fix: update e2e tests for newer changes in site
praveen-quizizz Oct 7, 2024
5419921
Merge branch 'develop' into fix/update-e2e-tests
NiallJoeMaher Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions e2e/home.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,20 +17,6 @@ test.describe("Confirm homepage content", () => {
await expect(page.locator("h3")).toContainText("Trending");
});

test("Different devices", async ({ page, isMobile }) => {
await page.goto("http://localhost:3000/");

const elementVisible = await page
.locator('text="Recommended topics"')
.isVisible();

if (isMobile) {
expect(elementVisible).toBe(false);
} else {
expect(elementVisible).toBe(true);
}
});

test.describe("Confirm image accessibiliy content", () => {
test("Shared content", async ({ page }) => {
// Accessibility
Expand Down
4 changes: 2 additions & 2 deletions e2e/login.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ test.beforeEach(async ({ page }) => {
test.describe("Login Page", () => {
test("should display the login button", async ({ page }) => {
const loginButton = page.getByRole("button", {
name: "Login with GitHub",
name: "Continue with GitHub",
});
expect(loginButton).toBeTruthy();
});
Expand All @@ -23,7 +23,7 @@ test.describe("Login Page", () => {
page,
}) => {
const button = page.getByRole("button", {
name: "Login with GitHub",
name: "Continue with GitHub",
});

await button.click();
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"prettier": "prettier --check -c '**/*.{ts,tsx,js,jsx,json,json5,scss,css,html,mdx}'",
"prettier:fix": "prettier --write -c '**/*.{ts,tsx,js,jsx,json,json5,scss,css,html,mdx}'",
"test": "npx playwright install && playwright test",
"test:e2e:ui": "ENV=local npx playwright test --ui",
"db:generate": "drizzle-kit generate",
"db:push": "drizzle-kit push",
"db:migrate": "npx tsx -r dotenv/config ./drizzle/migrate.ts",
Expand Down