Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar needs logging. Fixes #1258 #1370

Merged
merged 2 commits into from
Oct 29, 2018
Merged

Toolbar needs logging. Fixes #1258 #1370

merged 2 commits into from
Oct 29, 2018

Conversation

bangbangda
Copy link
Contributor

Description
Toolbar collector does not exists. log file is show they had a wrong classname.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@jim-parry jim-parry merged commit 40655e6 into codeigniter4:develop Oct 29, 2018
@bangbangda bangbangda deleted the toolbar-log branch October 30, 2018 00:47
@bangbangda bangbangda restored the toolbar-log branch October 30, 2018 00:47
@bangbangda bangbangda deleted the toolbar-log branch October 30, 2018 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bangbangda @jim-parry