Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO Toolbar needs logging #1258

Closed
jim-parry opened this issue Sep 27, 2018 · 4 comments
Closed

TODO Toolbar needs logging #1258

jim-parry opened this issue Sep 27, 2018 · 4 comments
Labels
missing feature Reported issue which is not a bug but needs to be implemented
Milestone

Comments

@jim-parry
Copy link
Contributor

Debug/Toolbar has a todo note...
Needs to be logged, in constructor

@jim-parry jim-parry added the missing feature Reported issue which is not a bug but needs to be implemented label Sep 27, 2018
@jim-parry jim-parry added this to the 4.0.1? milestone Sep 27, 2018
@bangbangda
Copy link
Contributor

More detailed description?
record the error message in the log file?

@jim-parry
Copy link
Contributor Author

The only "todo" mention I see in the Debug/Toolbar class is in the constructor, where it implies that any non-existing collectors should trigger a log message.
My guess is handling it similarly to Debug/Exceptions::exceptionHandler.
Someone party to the original implementation might be able to shed more light on the intent.

@lonnieezell
Copy link
Member

Yes, it was just to put something in the logs a developer could find to show they had a wrong classname. My usual preference is to throw an exception, but in this case didn't want to stop the toolbar from working, but did want to give the developer a chance to discover it.

@bangbangda
Copy link
Contributor

ok

jim-parry added a commit that referenced this issue Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing feature Reported issue which is not a bug but needs to be implemented
Projects
None yet
Development

No branches or pull requests

3 participants