Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<?m2e execute onConfiguration?> fails if pom is big enough (8kb) #22

Closed
michaldo opened this issue Feb 23, 2017 · 0 comments
Closed

<?m2e execute onConfiguration?> fails if pom is big enough (8kb) #22

michaldo opened this issue Feb 23, 2017 · 0 comments
Milestone
3.1.0

Comments

@michaldo
Copy link

pom.xml.txt

Steps to reproduce:

  1. Copy given pom.xml.txt and type mvn validate

Expected: pass
Actual: java.lang.ArrayIndexOutOfBoundsException: 8222

If you remove any fake banana properties from the file to decrease its size, it will pass.

I think something is wrong with buffer https://github.com/codehaus-plexus/plexus-utils/blob/master/src/main/java/org/codehaus/plexus/util/xml/pull/MXParser.java#L343
barclay-reg pushed a commit to barclay-reg/plexus-utils that referenced this issue Apr 2, 2017
@roka-actico
Fix off issue codehaus-plexus#22 <?m2e execute onConfiguration?> fail…
1bb3d93 
…s if pom is big enough (8kb)

* fixed pom parser, as logic to check for x-m-l letters does not respected input tokenization
barclay-reg added a commit to barclay-reg/plexus-utils that referenced this issue Apr 26, 2017
@barclay-reg
Fix off issue codehaus-plexus#22
86b68cd 
added unit tests
barclay-reg added a commit to barclay-reg/plexus-utils that referenced this issue Apr 27, 2017
@barclay-reg
Fix off issue codehaus-plexus#22
19d91ad 
fixed unit test, so it fails for the old code
* old unit test implementation was trapped by the buffer resizing (for the one, big 10k chars xml comment), so this was tailored into 10 * 1000 chars xml comments
rfscholte pushed a commit that referenced this issue Apr 27, 2017
@barclay-reg @rfscholte
Fix off issue #22 <?m2e execute onConfiguration?> fails if pom is big… (
dd1c85f 
#23)

* Fix off issue #22 <?m2e execute onConfiguration?> fails if pom is big enough (8kb)
* fixed pom parser, as logic to check for x-m-l letters does not respected input tokenization

* Fix off issue #22

added unit tests

* Fix off issue #22

fixed unit test, so it fails for the old code
* old unit test implementation was trapped by the buffer resizing (for the one, big 10k chars xml comment), so this was tailored into 10 * 1000 chars xml comments
@rfscholte rfscholte added this to the 3.1.0 milestone May 26, 2017
schereradi pushed a commit to schereradi/pom-explorer that referenced this issue Feb 21, 2020
Update maven-core dependency
53208b3 
Due to a bug in plexus-utils [1], there is an ArrayIndexOutOfBoundsException
if a big pom file is analyzed with the new M2Eclipse syntax for specifying
lifecycle mapping metadata [2]. The bug is already fixed in plexus-utils,
so only the maven-core and shrinkwrap-resolver* dependencies have to be
updated.

[1] codehaus-plexus/plexus-utils#22
[2] For example "<?m2e execute onConfiguration?>"
@lukehutch lukehutch mentioned this issue Mar 29, 2020
Closed
@johanneskraemer johanneskraemer mentioned this issue Mar 30, 2020
Closed
dsyer added a commit to spring-projects-experimental/spring-boot-thin-launcher that referenced this issue Oct 19, 2021
@dsyer
Upgrade Maven utilities to 3.5.4
62d4478 
There was a bug in plexus that made it fail with some pom.xml files
codehaus-plexus/plexus-utils#22
ltearno pushed a commit to ltearno/pom-explorer that referenced this issue May 6, 2022
@ltearno
Update maven-core dependency
c111403 
Due to a bug in plexus-utils [1], there is an ArrayIndexOutOfBoundsException
if a big pom file is analyzed with the new M2Eclipse syntax for specifying
lifecycle mapping metadata [2]. The bug is already fixed in plexus-utils,
so only the maven-core and shrinkwrap-resolver* dependencies have to be
updated.

[1] codehaus-plexus/plexus-utils#22
[2] For example "<?m2e execute onConfiguration?>"
@patrodyne patrodyne mentioned this issue Mar 3, 2023
Closed
@lynxSven lynxSven mentioned this issue Mar 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
2 participants
@rfscholte @michaldo