Skip to content

Commit

Permalink
Fix off issue codehaus-plexus#22
Browse files Browse the repository at this point in the history
fixed unit test, so it fails for the old code
* old unit test implementation was trapped by the buffer resizing (for the one, big 10k chars xml comment), so this was tailored into 10 * 1000 chars xml comments
  • Loading branch information
barclay-reg committed Apr 27, 2017
1 parent 86b68cd commit 19d91ad
Showing 1 changed file with 17 additions and 4 deletions.
21 changes: 17 additions & 4 deletions src/test/java/org/codehaus/plexus/util/xml/pull/MXParserTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -194,13 +194,17 @@ public void testSubsequentProcessingInstructionMoreThan8k()
sb.append("<?xml version=\"1.0\" encoding=\"UTF-8\"?>");
sb.append("<project>");

sb.append("<!-- ");

for (int i = 0; i < 1000; i++) {
sb.append("ten bytes ");
// add ten times 1000 chars as comment
for (int j = 0; j < 10; j++) {

sb.append("<!-- ");
for (int i = 0; i < 2000; i++) {
sb.append("ten bytes ");
}
sb.append(" -->");
}

sb.append(" -->");
sb.append("<?m2e ignore?>");
sb.append("</project>");

Expand All @@ -212,6 +216,15 @@ public void testSubsequentProcessingInstructionMoreThan8k()
assertEquals( XmlPullParser.PROCESSING_INSTRUCTION, parser.nextToken() );
assertEquals( XmlPullParser.START_TAG, parser.nextToken() );
assertEquals( XmlPullParser.COMMENT, parser.nextToken() );
assertEquals( XmlPullParser.COMMENT, parser.nextToken() );
assertEquals( XmlPullParser.COMMENT, parser.nextToken() );
assertEquals( XmlPullParser.COMMENT, parser.nextToken() );
assertEquals( XmlPullParser.COMMENT, parser.nextToken() );
assertEquals( XmlPullParser.COMMENT, parser.nextToken() );
assertEquals( XmlPullParser.COMMENT, parser.nextToken() );
assertEquals( XmlPullParser.COMMENT, parser.nextToken() );
assertEquals( XmlPullParser.COMMENT, parser.nextToken() );
assertEquals( XmlPullParser.COMMENT, parser.nextToken() );
assertEquals( XmlPullParser.PROCESSING_INSTRUCTION, parser.nextToken() );
assertEquals( XmlPullParser.END_TAG, parser.nextToken() );
}
Expand Down

0 comments on commit 19d91ad

Please sign in to comment.