sql: retry schema change on a communication error #28769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
vivekmenezes
force-pushed
the
commerror
branch
from
cf65d17 to
ff775cd
Compare
jordanlewis
reviewed
Aug 21, 2018
There was a problem hiding this comment.
Nervous about this... there are many, many internal errors that get returned by the system. I doubt that all of them are retriable. Can we go the opposite direction here, and change the DistSQL error being returned to have a retriable error that isn't internal error?
Reviewable status:
complete! 0 of 0 LGTMs obtained
return pgerror.CodeConnectionFailureError from distsql when it sees a communication error. related to cockroachdb#27958 Release note: None
vivekmenezes
force-pushed
the
commerror
branch
from
ff775cd to
b1caf5f
Compare
vivekmenezes
commented
Aug 21, 2018
There was a problem hiding this comment.
I've changed it to return and catch pgerror.CodeConnectionFailureError
Reviewable status:
vivekmenezes
changed the title
jordanlewis
approved these changes
Aug 21, 2018
|
bors r+ |
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Aug 22, 2018
28953: backport-2.1: sql: retry schema change on a communication error r=vivekmenezes a=vivekmenezes Backport 1/1 commits from #28769. /cc @cockroachdb/release --- return pgerror.CodeConnectionFailureError from distsql when it sees a communication error. related to #27958 Release note: None Co-authored-by: Vivek Menezes <vivek@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
return pgerror.CodeConnectionFailureError from distsql
when it sees a communication error.
related to #27958
Release note: None