Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: Seeing schema change rollback more often #27958

Closed
vivekmenezes opened this issue Jul 26, 2018 · 1 comment
Closed

sql: Seeing schema change rollback more often #27958

vivekmenezes opened this issue Jul 26, 2018 · 1 comment
Labels
A-schema-changes C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@vivekmenezes
Copy link
Contributor

after the change to isPermanentSchemaChangeError() in
87c4b07

we have been seeing more customers seeing rollbacks in schema changes. We should look at fine tuning this policy.
@vivekmenezes vivekmenezes added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-schema-changes labels Jul 26, 2018
@vivekmenezes vivekmenezes changed the title schema: Seeing schema change rollback more often sql: Seeing schema change rollback more often Jul 26, 2018
vivekmenezes added a commit to vivekmenezes/cockroach that referenced this issue Aug 17, 2018
@vivekmenezes
sql: mark expired schema change lease as a temporary error
9af16aa 
An expired schema change lease is no reason to rollback
a schema change. The schema change mechanism uses transactions
and doesn't need a guarantee that it only run by a single lease
holder. An expired lease should simply mean: stop and allow the
lease holder to proceed.

related to cockroachdb#27273
related to cockroachdb#27958
related to cockroachdb#27760

Release note: None
@vivekmenezes vivekmenezes mentioned this issue Aug 17, 2018
Merged
@vivekmenezes vivekmenezes mentioned this issue Aug 17, 2018
Merged
craig bot pushed a commit that referenced this issue Aug 17, 2018
@vivekmenezes
Merge #28762
ea7e255 
28762: sql: mark expired schema change lease as a temporary error r=vivekmenezes a=vivekmenezes

An expired schema change lease is no reason to rollback
a schema change. The schema change mechanism uses transactions
and doesn't need a guarantee that it only run by a single lease
holder. An expired lease should simply mean: stop and allow the
lease holder to proceed.

related to #27273
related to #27958
related to #27760

Release note: None

Co-authored-by: Vivek Menezes <vivek@cockroachlabs.com>
vivekmenezes added a commit to vivekmenezes/cockroach that referenced this issue Aug 21, 2018
@vivekmenezes
sql: mark expired schema change lease as a temporary error
65824d6 
An expired schema change lease is no reason to rollback
a schema change. The schema change mechanism uses transactions
and doesn't need a guarantee that it only run by a single lease
holder. An expired lease should simply mean: stop and allow the
lease holder to proceed.

related to cockroachdb#27273
related to cockroachdb#27958
related to cockroachdb#27760

Release note: None
@vivekmenezes vivekmenezes mentioned this issue Aug 21, 2018
Merged
craig bot pushed a commit that referenced this issue Aug 21, 2018
@vivekmenezes
Merge #28881
2f8aa8a 
28881: backport-2.0: sql: mark expired schema change lease as a temporary error r=vivekmenezes a=vivekmenezes

Backport 1/1 commits from #28762.

/cc @cockroachdb/release

---

An expired schema change lease is no reason to rollback
a schema change. The schema change mechanism uses transactions
and doesn't need a guarantee that it only run by a single lease
holder. An expired lease should simply mean: stop and allow the
lease holder to proceed.

related to #27273
related to #27958
related to #27760

Release note: None


Co-authored-by: Vivek Menezes <vivek@cockroachlabs.com>
vivekmenezes added a commit to vivekmenezes/cockroach that referenced this issue Aug 21, 2018
@vivekmenezes
sql: retry schema change on a communication error
b1caf5f 
return pgerror.CodeConnectionFailureError from distsql
when it sees a communication error.

related to cockroachdb#27958

Release note: None
craig bot pushed a commit that referenced this issue Aug 21, 2018
@vivekmenezes
Merge #28769
2b44a47 
28769: sql: retry schema change on a communication error r=vivekmenezes a=vivekmenezes

return pgerror.CodeConnectionFailureError from distsql
when it sees a communication error.

related to #27958

Release note: None

Co-authored-by: Vivek Menezes <vivek@cockroachlabs.com>
@vivekmenezes
Copy link
Contributor Author

marking this as fixed!

vivekmenezes added a commit to vivekmenezes/cockroach that referenced this issue Aug 22, 2018
@vivekmenezes
sql: retry schema change on a communication error
73e2a6c 
return pgerror.CodeConnectionFailureError from distsql
when it sees a communication error.

related to cockroachdb#27958

Release note: None
@vivekmenezes vivekmenezes mentioned this issue Aug 22, 2018
Merged
craig bot pushed a commit that referenced this issue Aug 22, 2018
@vivekmenezes
Merge #28953
0779085 
28953: backport-2.1: sql: retry schema change on a communication error r=vivekmenezes a=vivekmenezes

Backport 1/1 commits from #28769.

/cc @cockroachdb/release

---

return pgerror.CodeConnectionFailureError from distsql
when it sees a communication error.

related to #27958

Release note: None


Co-authored-by: Vivek Menezes <vivek@cockroachlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-schema-changes C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vivekmenezes