workload/schemachanger: ignore unique violation errors for CREATE INDEX #130351
Conversation
Previously, the schema changer workload added logic to ignore potential unique violation errors during CREATE UNIQUE INDEX. This logic was for the statement phase, which is not when this error would be noticed, so it did not work correctly. To address this, this patch adds the logic to make unique violations error as potential commit error for CREATE INDEX. Fixes: cockroachdb#129366 Release note: None
fqazi
requested review from
herkolategan and
renatolabs
and removed request for
a team
|
This change is |
fqazi
added
backport-24.1.x
|
@annrpom TFTR! bors r+ |
130039: logical: Test different connected graphs for ldr r=msbutler a=navsetlur All previous tests were A <-> B replication. This commit adds an acyclic test with multiple sources for one target, and another one with a fully connected replication graph. Release note: none Informs: #129890 130351: workload/schemachanger: ignore unique violation errors for CREATE INDEX r=fqazi a=fqazi Previously, the schema changer workload added logic to ignore potential unique violation errors during CREATE UNIQUE INDEX. This logic was for the statement phase, which is not when this error would be noticed, so it did not work correctly. To address this, this patch adds the logic to make unique violations error as potential commit error for CREATE INDEX. Fixes: #129366 Release note: None Co-authored-by: Naveen Setlur <naveen.setlur@cockroachlabs.com> Co-authored-by: Faizan Qazi <faizan@cockroachlabs.com>
|
Build failed (retrying...): |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #129366: branch-release-24.1, branch-release-24.2. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from fb7a8e8 to blathers/backport-release-24.1-130351: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 24.1.x failed. See errors above. error creating merge commit from fb7a8e8 to blathers/backport-release-24.2-130351: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 24.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Previously, the schema changer workload added logic to ignore potential unique violation errors during CREATE UNIQUE INDEX. This logic was for the statement phase, which is not when this error would be noticed, so it did not work correctly. To address this, this patch adds the logic to make unique violations error as potential commit error for CREATE INDEX.
Fixes: #129366
Release note: None