Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crosscluster/logical: test fully connected 4 way replication and dag replication #129890

Closed
msbutler opened this issue Aug 29, 2024 · 1 comment
Closed

crosscluster/logical: test fully connected 4 way replication and dag replication #129890

msbutler opened this issue Aug 29, 2024 · 1 comment
Assignees
@navsetlur
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) P-2 Issues/test failures with a fix SLA of 3 months T-disaster-recovery

Comments

@msbutler
Copy link
Collaborator

msbutler commented Aug 29, 2024 •
edited by cockroach-jira-scripts
Loading

We only test bidirectional replication. We should test the following topologies:

DAG:
A -> B -> C

and:

Fully Connected graph between 4 targets:
A, B, C, D, where each target connects to every other target.

Note: all these should be tested on a single test cluster to speed things up. Each target merely needs to be a separate table.

Jira issue: CRDB-41754
@msbutler msbutler added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery labels Aug 29, 2024
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Aug 29, 2024

cc @cockroachdb/disaster-recovery

@exalate-issue-sync exalate-issue-sync bot added the P-2 Issues/test failures with a fix SLA of 3 months label Sep 3, 2024
navsetlur added a commit to navsetlur/cockroach that referenced this issue Sep 3, 2024
@navsetlur
logical: Test different connected graphs for ldr
a397fe6 
All previous tests were A <-> B replication. This commit adds an
acyclic test with multiple sources for one target, and a fully
connected replication graph.

Release note: none
Informs: cockroachdb#129890
navsetlur added a commit to navsetlur/cockroach that referenced this issue Sep 3, 2024
@navsetlur
logical: Test different connected graphs for ldr
50447bc 
All previous tests were A <-> B replication. This commit adds an
acyclic test with multiple sources for one target, and a fully
connected replication graph.

Release note: none
Informs: cockroachdb#129890
navsetlur added a commit to navsetlur/cockroach that referenced this issue Sep 3, 2024
@navsetlur
logical: Test different connected graphs for ldr
94177f0 
All previous tests were A <-> B replication. This commit adds an
acyclic test with multiple sources for one target, and another one
with a fully connected replication graph.

Release note: none
Informs: cockroachdb#129890
@navsetlur navsetlur mentioned this issue Sep 3, 2024
Merged
navsetlur added a commit to navsetlur/cockroach that referenced this issue Sep 5, 2024
@navsetlur
logical: Test different connected graphs for ldr
ab52ce5 
All previous tests were A <-> B replication. This commit adds an
acyclic test with multiple sources for one target, and another one
with a fully connected replication graph.

Release note: none
Informs: cockroachdb#129890
navsetlur added a commit to navsetlur/cockroach that referenced this issue Sep 5, 2024
@navsetlur
logical: Test different connected graphs for ldr
defe325 
All previous tests were A <-> B replication. This commit adds a
test with multiple sources for one target, and another one with
a fully connected replication graph.

Release note: none
Informs: cockroachdb#129890
navsetlur added a commit to navsetlur/cockroach that referenced this issue Sep 5, 2024
@navsetlur
logical: Test different connected graphs for ldr
3a60efb 
All previous tests were A <-> B replication. This commit adds a
test with multiple sources for one target, and another one with
a fully connected replication graph.

Release note: none
Informs: cockroachdb#129890
navsetlur added a commit to navsetlur/cockroach that referenced this issue Sep 5, 2024
@navsetlur
logical: Test different connected graphs for ldr
e91731e 
All previous tests were A <-> B replication. This commit adds a
test with multiple sources for one target, and another one with
a fully connected replication graph.

Release note: none
Informs: cockroachdb#129890
navsetlur added a commit to navsetlur/cockroach that referenced this issue Sep 5, 2024
@navsetlur
logical: Test different connected graphs for ldr
150385a 
All previous tests were A <-> B replication. This commit adds a
test with multiple sources for one target, and another one with
a fully connected replication graph.

Release note: none
Informs: cockroachdb#129890
navsetlur added a commit to navsetlur/cockroach that referenced this issue Sep 5, 2024
@navsetlur
logical: Test different connected graphs for ldr
9954d20 
All previous tests were A <-> B replication. This commit adds a
test with multiple sources for one target, and another one with
a fully connected replication graph.

Release note: none
Informs: cockroachdb#129890
navsetlur added a commit to navsetlur/cockroach that referenced this issue Sep 6, 2024
@navsetlur
logical: Test different connected graphs for ldr
fb72ae1 
All previous tests were A <-> B replication. This commit adds a
test with multiple sources for one target, and another one with
a fully connected replication graph.

Release note: none
Informs: cockroachdb#129890
navsetlur added a commit to navsetlur/cockroach that referenced this issue Sep 9, 2024
@navsetlur
logical: Test different connected graphs for ldr
a7f55be 
All previous tests were A <-> B replication. This commit adds a
test with multiple sources for one target, and another one with
a fully connected replication graph.

Release note: none
Informs: cockroachdb#129890
navsetlur added a commit to navsetlur/cockroach that referenced this issue Sep 9, 2024
@navsetlur
logical: Test different connected graphs for ldr
34f1556 
All previous tests were A <-> B replication. This commit adds a
test with multiple sources for one target, and another one with
a fully connected replication graph.

Release note: none
Informs: cockroachdb#129890
navsetlur added a commit to navsetlur/cockroach that referenced this issue Sep 9, 2024
@navsetlur
logical: Test different connected graphs for ldr
68810d0 
All previous tests were A <-> B replication. This commit adds a
test with multiple sources for one target, and another one with
a fully connected replication graph.

Release note: none
Informs: cockroachdb#129890
navsetlur added a commit to navsetlur/cockroach that referenced this issue Sep 9, 2024
@navsetlur
logical: Test different connected graphs for ldr
b0bd929 
All previous tests were A <-> B replication. This commit adds a
test with multiple sources for one target, and another one with
a fully connected replication graph.

Release note: none
Informs: cockroachdb#129890
craig bot pushed a commit that referenced this issue Sep 9, 2024
@navsetlur @fqazi
Merge #130039 #130351
b5d2f67 
130039: logical: Test different connected graphs for ldr r=msbutler a=navsetlur

All previous tests were A <-> B replication. This commit adds an acyclic test with multiple sources for one target, and another one with a fully connected replication graph.

Release note: none
Informs: #129890

130351: workload/schemachanger: ignore unique violation errors for CREATE INDEX r=fqazi a=fqazi

Previously, the schema changer workload added logic to ignore potential unique violation errors during CREATE UNIQUE INDEX. This logic was for the statement phase, which is not when this error would be noticed, so it did not work correctly. To address this, this patch adds the logic to make unique violations error as  potential commit error for CREATE INDEX.

Fixes: #129366

Release note: None

Co-authored-by: Naveen Setlur <naveen.setlur@cockroachlabs.com>
Co-authored-by: Faizan Qazi <faizan@cockroachlabs.com>
craig bot pushed a commit that referenced this issue Sep 9, 2024
@navsetlur @renatolabs
Merge #130039 #130349
942d2f8 
130039: logical: Test different connected graphs for ldr r=msbutler a=navsetlur

All previous tests were A <-> B replication. This commit adds an acyclic test with multiple sources for one target, and another one with a fully connected replication graph.

Release note: none
Informs: #129890

130349: build: allow roachtest defaults to be overwritten r=rickystewart a=renatolabs

This allows the `PARALLELISM` and `CPUQUOTA` defaults to be overwritten when running experiments on TeamCity.

Epic: none

Release note: None

Co-authored-by: Naveen Setlur <naveen.setlur@cockroachlabs.com>
Co-authored-by: Renato Costa <renato@cockroachlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@navsetlur navsetlur

Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) P-2 Issues/test failures with a fix SLA of 3 months T-disaster-recovery
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msbutler @navsetlur