Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: Fix TypeScript error in TypeaheadSelect correctly #21199

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

lib: Fix TypeScript error in TypeaheadSelect correctly #21199

wants to merge 1 commit into from

Commits on Oct 31, 2024

  1. lib: Fix TypeScript error in TypeaheadSelect correctly 

    The "isDisabled" in the props needs to remain optional, otherwise
every user has to provide it. The default value in the function does
nothing for this.

The real problem was assigning that to MenuToggleProps, but there the
default value will make sure that isDisabled is not undefined anymore.
    @mvollmer
    mvollmer committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    90023d6 View commit details
    Browse the repository at this point in the history