lib: Fix TypeScript error in TypeaheadSelect correctly #21199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "isDisabled" in the props needs to remain optional, otherwise every user has to provide it. The default value in the function does nothing for this. The real problem was assigning that to MenuToggleProps, but there the default value will make sure that isDisabled is not undefined anymore.
martinpitt
approved these changes
Oct 31, 2024
|
It would be nice to find mistakes like this by actually running the type checker over the code that uses TypeaheadSelect, but I understand now why that is difficult. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "isDisabled" in the props needs to remain optional, otherwise every user has to provide it. The default value in the function does nothing for this.
The real problem was assigning that to MenuToggleProps, but there the default value will make sure that isDisabled is not undefined anymore.