Rawhide is broken #624
Merged
Rawhide is broken #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I saw almost the same failure in downstream: https://src.fedoraproject.org/rpms/cockpit-podman/pull-request/14 |
|
I booted F-32/rawhide prepared VM and: A bit more logs: Interestingly, when I boot VM, first time events time out after ~1.5 minute, when I try it again it never times out, any other subsequent call times out in ~1.5minute. |
martinpitt
previously approved these changes
Dec 16, 2020
There was a problem hiding this comment.
Thanks! That's in fact the very fix in containers/podman#8753 .
|
bah, does not seem to work :/ waiting for the result to see if the same problem or something different |
|
so still some failed user services but also now |
|
Oh and that |
|
@marusak: Quick idea: copy the unit to /etc or /run, they should both supersede units in /usr. |
1 task
martinpitt
previously approved these changes
Dec 17, 2020
test/vm.install
Outdated
Comment on lines
54
to
55
| sed -i "s/Type=notify/Type=exec/" /etc/systemd/system/podman.service | ||
| sed -i "s/Type=notify/Type=exec/" /etc/systemd/user/podman.service |
There was a problem hiding this comment.
Not important at all, just in general for next time: Have sed output to the new file instead of copy/in-place edit.
There was a problem hiding this comment.
oh duh, I was not thinking straight when I wrote this. If I have to repush I'll do that this way.
|
aargh, it is still failing. Can it be related to the fact, that our nond tests are touching etc? (When I prepare rawhide VM locally it never times out). |
|
On my way out, sorry. My go-to method for this is to have this helper in my bashrc: Then prepare a f32/rawhide VM, |
|
I can reproduce this just fine if I run two tests in a row. So there is some issue with cleanup. |
Not specifically, no. Also, they'd just restore what was on the original image, and the hack already happens in image-customize. In the worst case, move the hack into the |
|
This is "fun". So it seems that after our cleanup when we try to again use the socket it just hangs with reply. I am trying to figure out why it is doing that. |
Now podman shows `image` for given container as string, which was used when the container was created. So when we expect `busybox:latest` we need to create it from that.
marusak
force-pushed
the
rawhide
branch
2 times, most recently
from
cb94e8a
to
05f3baa
Compare
|
aaalmost there. One more flake and one more issue. The last one will need naughty, working on it now. |
We removed images, but `wait_visible` for `alpine:latest` could still sometimes see also the user ones, thus failing with ambiguous selectors.
|
this failure looks almost the same? May need an extension of the pattern? |
It is the same, it just ran with the current bots, so it does not see the new naughty yet. |
|
This was fun. 3 reports to podman later and this is ready for review. (+1 report from Marius to podman last week, not great podman, not great) |
martinpitt
approved these changes
Dec 17, 2020
| @@ -165,6 +165,10 @@ $(VM_IMAGE): $(VM_DEP) bots | |||
| rm -f $(VM_IMAGE) $(VM_IMAGE).qcow2 | |||
| bots/image-customize -v $(VM_PACKAGE) -s $(CURDIR)/test/vm.install $(TEST_OS) | |||
| $(RAWHIDE) | |||
| # HACK: systemd kills the services after 90s | |||
| # See https://github.com/containers/podman/issues/8751 | |||
| bots/image-customize -r "sed -i 's/Type=notify/Type=exec/' /usr/lib/systemd/system/podman.service" -r "sed -i 's/Type=notify/Type=exec/' /usr/lib/systemd/user/podman.service" $(TEST_OS) | |||
There was a problem hiding this comment.
I asked above to put this into the RAWHIDE= definition, but indeed you said in the upstream report that it already landed in F32/33, and Debian also has 2.2.1 now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.