Skip to content

Commit

Permalink
test: Fix race in image deletion
Browse files Browse the repository at this point in the history
We removed images, but `wait_visible` for `alpine:latest` could still
sometimes see also the user ones, thus failing with ambiguous selectors.
  • Loading branch information
marusak committed Dec 17, 2020
1 parent 3c8a6a5 commit f3ab2bc
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions test/check-application
Original file line number Diff line number Diff line change
Expand Up @@ -1103,14 +1103,16 @@ class TestApplication(testlib.MachineCase):
b = self.browser
m = self.machine

self.login_and_go("/podman", superuser=auth)

# Just drop user images so we can use simpler selectors
if auth:
# Just drop user containers so we can user simpler selectors
self.execute(False, "podman rmi alpine busybox registry:2")

self.login_and_go("/podman", superuser=auth)

b.wait_in_text("#containers-images", "busybox:latest")
b.wait_in_text("#containers-images", "alpine:latest")
if auth:
b.wait_not_in_text("#containers-images", "admin")

# Check command in alpine
b.wait_visible('#containers-images td[data-label="Name"]:contains("alpine:latest")')
Expand Down

0 comments on commit f3ab2bc

Please sign in to comment.