Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkpoint restore fixes #1149

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Conversation

jelly
Copy link
Member

@jelly jelly commented Nov 29, 2022

Ideally we would also test the TCP connection / MAC and IP related checkboxes on restore, but from a small test:

cat /sys/class/net/*/address

The MAC address does not really change, and we can't change it with the alpineimage as it has no.

Turns out while making this PR I realised we have a busybox image which has ip

But reading the man page.. we need to create a container with --mac-address and --ip to test this functionality. This can be done but from my testing it seems to be broken?!

podman run -dit --mac-address 92:d0:c6:0a:29:38 --name fo busybox:latest sh
podman container checkpoint fo
podman container restore --ignore-static-mac fo
podman inspect --format '{{.NetworkSettings.MacAddress}}' fo
[root@fedora-37-127-0-0-2-2201 ~]# podman inspect --format '{{.NetworkSettings.MacAddress}}' fo
92:d0:c6:0a:29:38

So this sounds like a podman bug, and I don't see any tests for it in their repository. Reported it here containers/podman#16666

We never passed the ignoreStaticIP or ignoreStaticMAC options to the
restore rest call.
KKoukiou
KKoukiou previously approved these changes Nov 29, 2022
Copy link
Contributor

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One relevant test failure: wait_js_cond(ph_is_present(".pf-c-modal-box input#checkpoint-dialog-ignoreRootFS:not([disabled]):not([aria-disabled=true])")): Uncaught (in promise) Error: condition did not become true

Otherwise looks great. :)

@KKoukiou KKoukiou dismissed their stale review November 29, 2022 12:26

Will approve atfer the test fix.

Ignoring the rootfs is only supported with an export as the man page
describes:

IMPORTANT: This OPTION only works in combination with --export, -e.
Copy link
Contributor

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Met dank :)

@jelly
Copy link
Member Author

jelly commented Nov 29, 2022

More testing farm issues...

> warning: Unhandled event type  volume
Error relocating /lib/ld-musl-x86_64.so.1: RELRO protection failed: Permission denied
Error relocating /bin/sh: RELRO protection failed: Permission denied

@jelly
Copy link
Member Author

jelly commented Nov 30, 2022

  • Rawhide issue is due to CRIU, should be fixed in bodhi / updates
  • Centos-stream-9 issue is separate and needs more investigation.

As both are unrelated to the PR, merging.

@jelly jelly merged commit 5ab45e4 into cockpit-project:main Nov 30, 2022
@jelly jelly deleted the checkpoint-restore-fixes branch November 30, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants