Skip to content

Commit

Permalink
Drop ignore rootfs from checkpoint
Browse files Browse the repository at this point in the history
Ignoring the rootfs is only supported with an export as the man page
describes:

IMPORTANT: This OPTION only works in combination with --export, -e.
  • Loading branch information
jelly committed Nov 30, 2022
1 parent 8a58218 commit 5ab45e4
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
5 changes: 0 additions & 5 deletions src/ContainerCheckpointModal.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,13 @@ const ContainerCheckpointModal = ({ containerWillCheckpoint, onAddNotification }
const [keep, setKeep] = useState(false);
const [leaveRunning, setLeaveRunning] = useState(false);
const [tcpEstablished, setTcpEstablished] = useState(false);
const [ignoreRootFS, setIgnoreRootFS] = useState(false);

const handleCheckpointContainer = () => {
setProgress(true);
client.postContainer(containerWillCheckpoint.isSystem, "checkpoint", containerWillCheckpoint.Id, {
keep,
leaveRunning,
tcpEstablished,
ignoreRootFS,
})
.catch(ex => {
const error = cockpit.format(_("Failed to checkpoint container $0"), containerWillCheckpoint.Names);
Expand Down Expand Up @@ -59,9 +57,6 @@ const ContainerCheckpointModal = ({ containerWillCheckpoint, onAddNotification }
<Checkbox label={_("Support preserving established TCP connections")}
id="checkpoint-dialog-tcpEstablished" name="tcpEstablished"
isChecked={tcpEstablished} onChange={setTcpEstablished} />
<Checkbox label={_("Do not include root file-system changes when exporting")}
id="checkpoint-dialog-ignoreRootFS" name="ignoreRootFS"
isChecked={ignoreRootFS} onChange={setIgnoreRootFS} />
</Form>
</Modal>
);
Expand Down
2 changes: 0 additions & 2 deletions test/check-application
Original file line number Diff line number Diff line change
Expand Up @@ -1132,7 +1132,6 @@ class TestApplication(testlib.MachineCase):
self.performContainerAction("busybox:latest", "Checkpoint")
b.set_checked('.pf-c-modal-box input#checkpoint-dialog-keep', True)
b.set_checked('.pf-c-modal-box input#checkpoint-dialog-tcpEstablished', True)
b.set_checked('.pf-c-modal-box input#checkpoint-dialog-ignoreRootFS', True)
b.click('.pf-c-modal-box button:contains(Checkpoint)')
b.wait_not_present('.modal_dialog')

Expand Down Expand Up @@ -1175,7 +1174,6 @@ class TestApplication(testlib.MachineCase):
self.performContainerAction("swamped-crate", "Checkpoint")
b.set_checked('.pf-c-modal-box input#checkpoint-dialog-keep', True)
b.set_checked('.pf-c-modal-box input#checkpoint-dialog-tcpEstablished', True)
b.set_checked('.pf-c-modal-box input#checkpoint-dialog-ignoreRootFS', True)
b.click('.pf-c-modal-box button:contains(Checkpoint)')

with b.wait_timeout(300):
Expand Down

0 comments on commit 5ab45e4

Please sign in to comment.