Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muon CITK fix #9964

Merged
merged 1 commit into from
Jul 7, 2015
Merged

Muon CITK fix #9964

merged 1 commit into from
Jul 7, 2015

Conversation

jhgoh
Copy link
Contributor

@jhgoh jhgoh commented Jun 30, 2015

This PR includes fix of configuration files + minor changes in example code.

The veto cone sizes in the CITK configuration was set incorrectly thus giving inconsistent isolation value to the standard isodeposit one.
After the fix, all muon candidate shows no difference to the standard one.

Also the analyzer module in PatExample is updated to read from pat muons for convenience and consistency.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jhgoh (Junghwan John Goh) for CMSSW_7_6_X.

Muon CITK fix

It involves the following packages:

PhysicsTools/PatExamples
RecoMuon/MuonIsolation

@cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@imarches, @pvmulder, @acaudron, @abbiendi, @bellan, @ferencek, @battibass, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Jun 30, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants