Muon Common Isolation Framework and Versionned ID #9459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 Another change was made in non-Reco code after this PR was approved for the second time by Reco. New Jenkins tests still show no significant differences, as expected. Jenkins tests are incomplete because of an IB problem, but this PR passed the tests previously and is not expected to change monitored quantities in any case. |
|
@monttj please check this PR, your signature is needed here |
| @@ -12,6 +12,7 @@ | |||
| <use name="Geometry/Records"/> | |||
| <use name="Geometry/CaloTopology"/> | |||
| <use name="PhysicsTools/IsolationAlgos"/> | |||
| <use name="PhysicsTools/SelectorUtils"/> | |||
There was a problem hiding this comment.
@slava77 - so not specific to this PR - but we should move things in PhysicsTools that Reco* needs into CommonTools. That will make it much easier to disintangle dependencies
davidlange6
added a commit
that referenced
this pull request
Jun 19, 2015
Muon Common Isolation Framework and Versionned ID
jhgoh
added a commit
to jhgoh/cmssw
that referenced
this pull request
Jul 10, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The common isolation framework (CITK) and Versioned-ID (VID) are applied to muons.
Simple wrapper to the Muon POG standard ID selectors are added with working initial configuration files.
No change to standard RECO is expected since it is designed to run on AOD or MiniAOD.
This PR supersedes previous attempt #9273.
Some safeguards are also included which are suggested by @cvuosalo in the previous PR.