adding David Lange's comments built on rebase of ValidationDoubleCountin... #9765
Conversation
…tingFix fixing missing files
|
A new Pull Request was created by @cmsbuild for CMSSW_7_6_X. adding David Lange's comments built on rebase of ValidationDoubleCountin... It involves the following packages: Validation/EventGenerator @vciulli, @covarell, @deguio, @danduggan, @thuer, @cmsbuild, @bendavid can you please review it and eventually sign? Thanks. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
+1 |
…ix_v2 adding David Lange's comments built on rebase of ValidationDoubleCountin...
| return true; | ||
| } | ||
|
|
||
| const HepMC::GenParticle* GetFinal(const HepMC::GenParticle* p){ // includes mixing |
There was a problem hiding this comment.
@davidlange6 , this is PR after which couple of workflows (533.0 and 534.0) in 76X are not finishing (timing out after 1 hour). Looks like GetFinal method is getting called recursively
|
@smuzaffar - ok - will try to revert then. (likely it won't merge) |
...gFix fixing missing files
Replaces pull 8676
Automatically ported from CMSSW_7_5_X #8850 (original by @inugent).