adding David Lange's comments built on rebase of ValidationDoubleCountin... #8850
Conversation
…tingFix fixing missing files
|
A new Pull Request was created by @inugent for CMSSW_7_5_X. adding David Lange's comments built on rebase of ValidationDoubleCountin... It involves the following packages: Validation/EventGenerator @vciulli, @covarell, @deguio, @danduggan, @thuer, @cmsbuild, @nclopezo, @bendavid can you please review it and eventually sign? Thanks. |
|
Note: missing files refers to files missing by git add when setting up this branch (they were in the original pull request 8676). |
|
in general there is no need to open a new PR. pushing to the same branch updates the existing one. |
| DQMHelper dqm(&i); i.setCurrentFolder("Generator/BPhysics"); | ||
| Nobj = dqm.book1dHisto("N"+name, "N"+name, 1, 0., 1,"bin","Number of "+name); | ||
| particle.Configure(i); | ||
| for(unsigned int j=0;j<daughters.size();j++){std::cout << j << std::endl; daughters[j].Configure(i);} |
|
+1 |
|
Comparison is ready The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
|
-1 |
|
replaced by #9765 |
...gFix fixing missing files
Replaces pull 8676