-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary Fix to match Hcal Trig Towers #9670
Conversation
A new Pull Request was created by @vkhristenko (Viktor Khristenko) for CMSSW_7_5_X. Temporary Fix to match Hcal Trig Towers It involves the following packages: DQM/HcalMonitorTasks @cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
-1 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15.log ----- Begin Fatal Exception 18-Jun-2015 18:58:47 CEST----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=MixingModule label='mix' Exception Message: RootEmbeddedFileSequence no input files specified for secondary input source. ----- End Fatal Exception ------------------------------------------------- you can see the results of the tests here: |
I've mentioned that I didn't run runTheMatrix on 75. VK On Thu, Jun 18, 2015 at 6:59 PM, cmsbuild notifications@github.com wrote:
|
This test failed due to a (tech.) issue unrelared to this PR. |
the underlying cause is failures in DAS queries for the input files. |
May we have it re-tested and merged asap? |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
May we have it re-tested and merged? It made it already to 74X and 76X. |
Temporary Fix to match Hcal Trig Towers
Below is the copy from PR for CMSSW_7_4_X:
An inconsistency in the HCAL TrigDetId treatment introduced by
PR #7950/#8103 outside DQM causes mismatch between HCAL TrigTowers from
data and L1 emulator. It will take some time to make a self-consistent
fix.
An urgent quick fix. Didn't do runTheMatrix for 75....
VK