Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary Fix to match Hcal Trig Towers #9670

Merged
merged 1 commit into from
Jul 7, 2015

Conversation

vkhristenko
Copy link
Contributor

Below is the copy from PR for CMSSW_7_4_X:

An inconsistency in the HCAL TrigDetId treatment introduced by
PR #7950/#8103 outside DQM causes mismatch between HCAL TrigTowers from
data and L1 emulator. It will take some time to make a self-consistent
fix.

An urgent quick fix. Didn't do runTheMatrix for 75....
VK

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vkhristenko (Viktor Khristenko) for CMSSW_7_5_X.

Temporary Fix to match Hcal Trig Towers

It involves the following packages:

DQM/HcalMonitorTasks

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Jun 18, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1
Tested at: 50cb3e6
When I ran the RelVals I found an error in the following worklfows:
25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15.log
----- Begin Fatal Exception 18-Jun-2015 18:58:47 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9670/5556/summary.html

@vkhristenko
Copy link
Contributor Author

I've mentioned that I didn't run runTheMatrix on 75.
Also, the problem is unrelated to HCAL DQM.

VK

On Thu, Jun 18, 2015 at 6:59 PM, cmsbuild notifications@github.com wrote:

-1
Tested at: 50cb3e6
50cb3e6
When I ran the RelVals I found an error in the following worklfows:
25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15.log

----- Begin Fatal Exception 18-Jun-2015 18:58:47 CEST-----------------------

An exception of category 'Configuration' occurred while

[0] Constructing the EventProcessor

[1] Constructing module: class=MixingModule label='mix'

Exception Message:

RootEmbeddedFileSequence no input files specified for secondary input source.

----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9670/5556/summary.html


Reply to this email directly or view it on GitHub
#9670 (comment).

@abdoulline
Copy link

This test failed due to a (tech.) issue unrelared to this PR.
To me it looks like step3 configuration inconsistency in this particular 25202.0 test
as cmsDriver command specifies PU and Mixing (for Raw2Digi -> L1 -> RECO schedule ?)
while no PU files appear in the resulting config.

@slava77
Copy link
Contributor

slava77 commented Jun 19, 2015

the underlying cause is failures in DAS queries for the input files.

@abdoulline
Copy link

May we have it re-tested and merged asap?
We do need it now in 74X.
Well, 7_4_5 has just been cut without it, so would be nice to have it at least in the next 74X...

@deguio
Copy link
Contributor

deguio commented Jun 24, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@abdoulline
Copy link

May we have it re-tested and merged? It made it already to 74X and 76X.

davidlange6 added a commit that referenced this pull request Jul 7, 2015
Temporary Fix to match Hcal Trig Towers
@davidlange6 davidlange6 merged commit 9423baf into cms-sw:CMSSW_7_5_X Jul 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants