Update HCAL Packing/Unpacking #7950
Conversation
We can now just check "m_flavor == 2" directly instead of checking part of the bits to see if it is 2 or 3.
This method works for flavor 2 and 4; all other flavors do not define an OK bool and so it returns 'false'.
After the header, ++ should only move 16 bits (1 row) as that is where the data starts, but after that it should move 32 bits (2 rows) as that is how each data entry is formatted.
…ld be ready to use
The L1RCTs only work with the old segmentation (version 0 for <= 2012), so if the version is anything else, we continue.
We use the tens digit in the depth field from the text file to indicate version. >= 10 is version 1, < 10 is version 0.
Previously it was hardcoded to be 0, which meant the unpacker treated everything as HO. It is now set by HcalHTRData::packHeaderTrailer. Also fix a Channel ID bug in HcalHTRData.cc
These bugs prevented HCAL Trigger Towers from properly being converted to RAW.
Previously processTrig always returned 0 because the "size" variable was set to 0, then not actually used to hold the size of the vector, and finally returned. Now size is properly set to the size of the vector.
|
A new Pull Request was created by @agude (Alexander Gude) for CMSSW_7_5_X. Update HCAL Packing/Unpacking It involves the following packages: CalibFormats/HcalObjects @civanch, @diguida, @cvuosalo, @mdhildreth, @cmsbuild, @nclopezo, @cerminar, @slava77, @mmusich, @mulhearn can you please review it and eventually sign? Thanks. |
|
Hi @agude |
|
It should be easy to pull that out and apply it. It is just the following commits, which I don't believe depend on the rest: There was some discussion via email about asking for some of the other commits to be backported as well, but that's outside my pay grade; its something for @jmmans and @abdoulline. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
|
+1 |
cmsbuild
added
alca-approved
comparison-available
dqm-approved
fully-signed
l1-approved
orp-approved
reconstruction-approved
simulation-approved
tests-started
and removed
alca-approved
comparison-available
dqm-approved
fully-signed
l1-approved
orp-pending
reconstruction-approved
simulation-approved
tests-started
labels
…5-02-25-0200_extra Update HCAL Packing/Unpacking
Several related HCAL uHTR Packing/Unpacking changes are included in this request:
CC: @jmmans, @abdoulline