Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heppy 7 4 4 patch4 #9544

Merged
merged 51 commits into from
Jun 19, 2015
Merged

Heppy 7 4 4 patch4 #9544

merged 51 commits into from
Jun 19, 2015

Conversation

cbernet
Copy link
Contributor

@cbernet cbernet commented Jun 10, 2015

Hello,

Here is a new version of heppy for CMSSW_7_4_X. This version contains important bug fixes, and is compatible with ipython 3.1. I am going to request ipython 3.1 for 74X in cmsdist now and link the two pull requests together.

It would be great if these two requests could enter CMSSW at the same time.

@arizzi @gpetruc : we do a PR later with new changes from you guys anytime you want after the migration to ipython 3.1. Here, I'm only fixing critical problems.

@Degano : same stuff as what we discussed for 75X.

Colin

arizzi and others added 30 commits May 11, 2015 14:30
Thanks Andrea, I'm merging only now cause I wanted to wait for the branch to be merged in CMSSW.
…s called, what seems needed for the moment for the isValid() method to work properluy
@cbernet
Copy link
Contributor Author

cbernet commented Jun 10, 2015

I think it may be this one, but @Degano can confirm:
https://github.com/degano/cmsdist/commit/0b04ae9641bda3016371bc62e43bfd8656cffd14
I had tested that heppy and ipython are working in 75X before the integration.

What I see is that ipython 3.1.0 is in the 75X IB.

@davidlange6
Copy link
Contributor

Perfect - thanks

On Jun 10, 2015, at 4:40 PM, Colin Bernet notifications@github.com wrote:

I think it may be this one, but @Degano can confirm:
degano/cmsdist@0b04ae9
I had tested that heppy and ipython are working in 75X before the integration.

What I see is that ipython 3.1.0 is in the 75X IB.


Reply to this email directly or view it on GitHub.

@cbernet
Copy link
Contributor Author

cbernet commented Jun 11, 2015

As said in the cmsdist PR, Alessandro provided a testing recipe, and I could test that in the most recent IB:

  • ipython 3.1 is set
  • the version of heppy in this branch works with ipython 3.1

@ghost
Copy link

ghost commented Jun 11, 2015

+tested
I compiled this manually against cms-sw/cmsdist#1617 external.
Ran the usual tests: 1306.0,101.0,1003.0,50202.0,9.0,25202.0.

@ghost
Copy link

ghost commented Jun 11, 2015

hold
This is to prevent automatic merge once all the signatures will be in place, since this PR needs to go in along the cmsdist one.

davidlange6 added a commit that referenced this pull request Jun 19, 2015
@davidlange6 davidlange6 merged commit be4d438 into cms-sw:CMSSW_7_4_X Jun 19, 2015
@cbernet cbernet deleted the heppy_7_4_4_patch4 branch October 1, 2015 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants