chain allows also LFN #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! do you guarantee that chain is working? From what I can see that must be the case, but I'd like your confirmation that everything has been checked. If that's the case, I'll merge this right away in the CMSSW PR. |
|
indeed, there was a mistake which didn't come out in previous tests, now fixed. is there a place for a unit test? |
|
You are very welcome to modify the existing unit test :-) Cheers, Colin Le 13 juin 2015 à 21:18, Joosep Pata notifications@github.com a écrit :
|
|
I've added a test for the new functionality which passes. |
cbernet
added a commit
that referenced
this pull request
Jun 13, 2015
Thanks for this improvement Joosep!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as #38 but against 744p4.