adding ME0 for recolocal

[archiesharma]

adding ME0 files in the local reconstruction

[cmsbuild]

A new Pull Request was created by @archiesharma for CMSSW_7_5_X.

adding ME0 for recolocal

It involves the following packages:

DataFormats/GEMRecHit
RecoLocalMuon/GEMRecHit

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@bellan, @abbiendi, @trocino, @jhgoh, @battibass this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

all code has to be "modernized" for 75X releases:

• use stream or global producer base class https://indico.cern.ch/event/351556/contribution/2/material/slides/0.pdf https://twiki.cern.ch/twiki/bin/view/CMSPublic/FWMultithreadedFrameworkModuleTypes#Stream_Module
• declare all consumed products and use getByToken https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideEDMGetDataFromEvent#Registering_for_data_access

These are prerequisites to get to 75X

[slava77]

I'm reposting my comment made inline in the code here:

all code has to be "modernized" for 75X releases:

• use stream or global producer base class https://indico.cern.ch/event/351556/contribution/2/material/slides/0.pdf https://twiki.cern.ch/twiki/bin/view/CMSPublic/FWMultithreadedFrameworkModuleTypes#Stream_Module
• declare all consumed products and use getByToken https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideEDMGetDataFromEvent#Registering_for_data_access

These are prerequisites to get to 75X

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[slava77]

@mark-grimes
Mark, do we have some kind of a checklist for people moving their code from SLHC to 75X release?

[I also missed eras in my prerequisites list]

[cmsbuild]

+1
Tested at: e1a5c83
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8912/4456/summary.html

[cvuosalo]

+1

For #8912 d9d77f0

This PR was already approved once by Reco (see above). A new change was made to delete unused functions from the code.

The code changes are satisfactory, and new Jenkins tests against baseline CMSSW_7_5_X_2015-05-17-2300 show no problems.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @smuzaffar

[davidlange6]

+1