-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gem segment 76 #10485
Gem segment 76 #10485
Conversation
PRToFixMess_ME0Segment_PR_v1
for (auto rh=rechits.begin(); rh!=rechits.end(); ++rh){ | ||
timeUncrt += pow((*rh)->tof()-averageTime,2); | ||
} | ||
if(rechits.size() != 0) timeUncrt=timeUncrt/(rechits.size()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will be exactly 0 for rechits = 1; not sure it matters, but still worth to note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noted, but does not matter, because the segment is only made when there are 2 or more hits.
@pietverwilligen please let me know your plans about #10485 (comment) |
please test. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
Pull Request for making segments in ME0. This is one of the last PRs for porting Muon Upgrade code from SLHC to 76X. Last PR to be expected is a PR containing code to reconstruct ME0Muons starting from these ME0 segments.
@cvuosalo I have tried as much as possible to check for comments you made for the GEMCSC Segment PR #9083 and to comments made earlier to ME0Segment code in PR #8912.
@slava77 and @cvuosalo please let me know your comments.
greets
Piet