Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase1 (2015 + Pixel Phase1) Workflow up to Reco #7645

Closed

Conversation

makortel
Copy link
Contributor

This PR is an update of #7625 adding fixes to tracking configuration. Original description of #7625:

This PR is modifying the 2017 scenario workflow to make it run till the reconstruction .
This is part of merging the upgrade code in &X cycle.

At this point it fails at the tracking step (*).
The geometry and local reco should now be validated while the reco step needs a bit more work.
Recipe : RunTheMatrix --what upgrade -l 10000

Run1/run2 workflows and code are unchanged.

and changes on top of that

  • Bug fix in QuadrupletSeedMerger
  • Typo fix in Phase1PU70_LowPtTripletStep_cff.py
  • Move clustersToSkip parameter from TrajectoryBuilders to CkfTrackCandidateMaker in Phase1 configuration files
  • Migrate Phase1 configuration files to use refToPSet_ for PixelSeedMergerQuadruplets

The RAW2DIGI,L1Reco,RECO step of wf 10000 still fails though (in 740pre6), now with

in filling An exception of category 'InvalidReference' occurred.
Exception Message:
Trie::insert called with a key already in collection;
key value: ^A

304091140 1

<snip>

An exception of category 'BadAlloc' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'raw2digi_step'
   [2] Calling event method for module HcalRawToDigi/'hcalDigis'
   [3] Using EventSetup component HcalDbProducer/'hcal_db_producer' to make data HcalDbService/'' in record HcalDbRecord
   [4] Using EventSetup component HcalHardcodeCalibrations/'es_hardcode' to make data HcalRespCorrs/'' in record HcalRespCorrsRcd
Exception Message:
A std::bad_alloc exception was thrown.
The job has probably exhausted the virtual memory available to the process.

@threus , @venturia , @boudoul, @atricomi, @rovere, @vinn, @veszpv, @mark-grimes : FYI

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_4_X.

Phase1 (2015 + Pixel Phase1) Workflow up to Reco

It involves the following packages:

Configuration/PyReleaseValidation
Geometry/CMSCommonData
RecoPixelVertexing/PixelTriplets
RecoTracker/ConversionSeedGenerators
RecoTracker/IterativeTracking
SLHCUpgradeSimulations/Configuration
SLHCUpgradeSimulations/Geometry

@civanch, @Dr15Jones, @cvuosalo, @boudoul, @ianna, @mdhildreth, @cmsbuild, @srimanob, @nclopezo, @franzoni, @slava77, @ktf can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @gpetruc, @cerati, @dgulhan, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@venturia
Copy link
Contributor

The first part of the errors reported by Matti:
Exception Message:
Trie::insert called with a key already in collection;
key value: ^A

304091140 1

is a side effect of my changes in the way multiple geometries are handled and it is harmless. We will address it later but for the moment can be ignored.

@slava77
Copy link
Contributor

slava77 commented Feb 10, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Feb 18, 2015

Is there much benefit to have this in 74X?
We can just continue in 75X.

@davidlange6
Copy link
Contributor

closing in 74x - there is the same PR open in 75x (now the development release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants