Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Measurement tracker redesign v1.1 #1063

Merged
merged 14 commits into from
Oct 11, 2013
Merged

Measurement tracker redesign v1.1 #1063

merged 14 commits into from
Oct 11, 2013

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Oct 11, 2013

Update of #1048 (which in turn was an update of #915)

  • merges in HLT fixes from @Martin-Grunewald
  • fix runTheMatrix workflows for HI (140.51) and Skimming (1000.0) by adding a MeasurementTrackerEvent producer in the sequence
  • fix the cosmic workflow (runTheMatrix 4.22) by removing top-bottom tracking for the moment (it will need more work to fix, as it uses an obsolete way of removing clusters)

gpetruc and others added 14 commits September 25, 2013 12:41
@gpetruc
MeasurementTracker Redesign, as presented in the RECO meeting on 2013…
44af4d9 
…-10-19

https://indico.cern.ch/getFile.py/access?contribId=8&sessionId=0&resId=1&materialId=slides&confId=265609
@gpetruc
Add MeasurementTrackerEvent producer in cosmic sequence (fix runTheMa…
f8acb34 
…trix workflow 1000.0)
@gpetruc
cfi changes for HLT ConfDB parsing (offline unaffected)
c4ac875
@gpetruc
fix missing comma
51fa268
@Martin-Grunewald
Merged refs/pull/915/head from repository cms-sw
11b614c
@gpetruc
Merged MeasurementTracker-redesign-v1 from repository gpetruc
330dd6f
@gpetruc
Fixes for HLT cfi's
8f691c5
@Martin-Grunewald
MeasurementTrackerAndHLT
88f0e2a
@Martin-Grunewald
More MT-fixes for FastSim, PIon, HIon
f27566c
@Martin-Grunewald
More MT fixes
6e91782
@gpetruc
Merged MeasurementTrackerAndHLT from repository Martin-Grunewald
794aa8f
@gpetruc
TrackRefitter needs a MeasurementTrackerEvent (fix runTheMatrix 1000.…
0582900 
…0 workflow)
@gpetruc
Need a MeasurementTrackerEvent in addition to trackerlocalreco
6373d1f
@gpetruc
Take out top-bottom cosmics until it is ported to the new cluster rem…
8d229f7 
…oval
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_7_0_X.

Measurement tracker redesign v1.1

It involves the following packages:

RecoEgamma/EgammaElectronProducers
RecoTracker/SpecialSeedGenerators
HLTrigger/Configuration
TrackingTools/MeasurementDet
RecoEgamma/EgammaElectronAlgos
RecoTracker/TkTrackingRegions
RecoTracker/ConversionSeedGenerators
RecoMuon/TrackerSeedGenerator
RecoTracker/Configuration
RecoTracker/TrackProducer
RecoMuon/L3TrackFinder
CalibTracker/SiStripHitEfficiency
FastSimulation/Tracking
Configuration/Skimming
RecoTracker/DebugTools
RecoEgamma/EgammaPhotonAlgos
RecoTracker/NuclearSeedGenerator
RecoTracker/CkfPattern
Configuration/StandardSequences
RecoEgamma/EgammaPhotonProducers
RecoTracker/IterativeTracking
RecoTracker/MeasurementDet
FastSimulation/Muons

@perrotta, @smuzaffar, @thspeer, @vlimant, @demattia, @fwyzard, @Martin-Grunewald, @franzoni, @nclopezo, @rcastello, @giamman, @slava77, @fabiocos can you please review it and eventually sign? Thanks.
@ghellwig, @cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@slava77
Copy link
Contributor

slava77 commented Oct 11, 2013

@slava77 working on it

@slava77
Copy link
Contributor

slava77 commented Oct 11, 2013

+1

tested 8d229f7 in CMSSW_7_0_X_2013-10-03-1400 (test area code sign256-1063)
No crashes anymore (compared to #1048 )

No differences in RECO
The same minor differences are visible in muon HLT tracks wrt baseline as was between #1048 and the baseline
(confirmed that #1063 and #1048 have identical outputs).

Timing, based on TTBar PU 202.0 (200 events):
about the same (a few % variations likely dependent on load).
The only significant diff is in
module newTotal, ms refTotal,ms new/ref
ecalDrivenElectronSeeds 23016.2 30864.8 0.74571

@ktf
Copy link
Contributor

ktf commented Oct 11, 2013

Trusting Slava and merging this, given Martin already agreed in the other #1048 request. In any case this is more likely to converge from this point onwards.

ktf added a commit that referenced this pull request Oct 11, 2013
@ktf
Merge pull request #1063 from gpetruc/MeasurementTracker-redesign-v1.1
703489b 
Reco improvements -- Measurement tracker redesign v1.1
@ktf ktf merged commit 703489b into cms-sw:CMSSW_7_0_X Oct 11, 2013
@slava77 slava77 mentioned this pull request Oct 13, 2013
Merged
makortel added a commit to makortel/cmssw that referenced this pull request Feb 9, 2015
@makortel
Move 'clustersToSkip' from TrajectoryBuilder to CkfTrackCandidateMake…
7a1f93c 
…r in Phase1 tracking configuration

Following what was done in cms-sw#1063.
makortel added a commit to makortel/cmssw that referenced this pull request Feb 10, 2015
@makortel
Move 'clustersToSkip' from TrajectoryBuilder to CkfTrackCandidateMake…
d14747c 
…r in Phase1 tracking configuration

Following what was done in cms-sw#1063.
@makortel makortel mentioned this pull request Feb 10, 2015
Closed
makortel added a commit to makortel/cmssw that referenced this pull request Feb 13, 2015
@makortel
Move 'clustersToSkip' from TrajectoryBuilder to CkfTrackCandidateMake…
92abe70 
…r in Phase1 tracking configuration

Following what was done in cms-sw#1063.
@cmsbuild cmsbuild mentioned this pull request Feb 17, 2015
Merged
ianna pushed a commit to ianna/cmssw that referenced this pull request Feb 23, 2015
@makortel @ianna
Move 'clustersToSkip' from TrajectoryBuilder to CkfTrackCandidateMake…
9d1664e 
…r in Phase1 tracking configuration

Following what was done in cms-sw#1063.
ianna pushed a commit to ianna/cmssw that referenced this pull request Feb 23, 2015
@makortel @ianna
Move 'clustersToSkip' from TrajectoryBuilder to CkfTrackCandidateMake…
ab33818 
…r in Phase1 tracking configuration

Following what was done in cms-sw#1063.
ianna pushed a commit to ianna/cmssw that referenced this pull request Feb 24, 2015
@makortel @ianna
Move 'clustersToSkip' from TrajectoryBuilder to CkfTrackCandidateMake…
92f43dd 
…r in Phase1 tracking configuration

Following what was done in cms-sw#1063.
@gpetruc gpetruc deleted the MeasurementTracker-redesign-v1.1 branch September 30, 2015 21:44
EmyrClement pushed a commit to EmyrClement/cmssw that referenced this pull request Feb 9, 2023
@cecilecaillol
Merge pull request cms-sw#1063 from gpetruc/update_correlator_v1.14_r…
0a9a5dd 
…ebased

Update Correlator code to l1ct-123x-v1.14, rebased
aloeliger added a commit to aloeliger/cmssw that referenced this pull request Apr 5, 2023
@aloeliger @thesps
@slaurila @thomreis @cerminar @gpetruc
Correlator PR corresponding to l1t-offline cms-sw#1063
4b4967d 
Co-authored-by: Sioni Summers <sioni.paris.summers@cern.ch>
Co-authored-by: Santeri Laurila <santeri.laurila@cern.ch>
Co-authored-by: Thomas Reis <thomas.reis@cern.ch>
Co-authored-by: Gianluca Cerminara <gianluca.cerminara@cern.ch>
Co-authored-by: Dylan Rankin <dylan.sheldon.rankin@cern.ch>
Co-authored-by: Giovanni Petrucciani <giovanni.petrucciani@cern.ch>
Co-authored-by: Emyr Clement <emyr.john.clement@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-pending fastsim-pending hlt-pending operations-pending pending-signatures reconstruction-approved tests-pending
Projects
None yet
Milestone
CMSSW_7_0_0_pre6
Development

Successfully merging this pull request may close these issues.
5 participants
@gpetruc @cmsbuild @slava77 @ktf @Martin-Grunewald