Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to prepare for AXOL1TL v5 (15_0_X) #47552

Open
wants to merge 3 commits into
base: CMSSW_15_0_X
Choose a base branch
from

Conversation

quinnanm
Copy link
Contributor

@quinnanm quinnanm commented Mar 11, 2025

PR description:

related PR (15_1_X): #47564

Small changes to the AXOL1TL emulator are added for compatibility with the new version 5 model. This is dependent on cms-dist PR for the new model (cms-sw/cmsdist#9741, cms-sw/cmsdist#9744) and assumes integration of v5 into the next menu.
A JIRA ticket for the menu changes and new model thresholds is planned imminently.

The code has 2 main changes:

  • the eta and phi of muon objects has been modified slightly to better match firmware implementation (ie hwEta->hwEtaAtVtx)
  • the model types have been updated for v5

PR validation:

This code has been validated with the new model version and all standard code checks have been performed.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @quinnanm for CMSSW_15_0_X.

It involves the following packages:

  • L1Trigger/L1TGlobal (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 11, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor

mmusich commented Mar 11, 2025

test parameters:

@mmusich
Copy link
Contributor

mmusich commented Mar 11, 2025

@quinnanm

  • can you change the title of the PR to be a little more descriptive of the changes?

  • A JIRA ticket for the menu changes and new model thresholds is planned imminently.

    Does this imply this PR will not pass tests until there's a new L1T menu in place where needed?

@quinnanm quinnanm changed the title v5 changes Changes to prepare for AXOL1TL v5 Mar 11, 2025
@quinnanm quinnanm changed the title Changes to prepare for AXOL1TL v5 Changes to prepare for AXOL1TL v5 (15_0_X) Mar 11, 2025
@quinnanm
Copy link
Contributor Author

@quinnanm

  • can you change the title of the PR to be a little more descriptive of the changes?

done!

  • A JIRA ticket for the menu changes and new model thresholds is planned imminently.

    Does this imply this PR will not pass tests until there's a new L1T menu in place where needed?

no, this should pass tests regardless. it should be compatible with previous menus, and prepares for the next one.

@mmusich
Copy link
Contributor

mmusich commented Mar 11, 2025

done!

thanks. Where is the equivalent master PR (for the CMSSW_15_1_X branch?)

@cmsbuild
Copy link
Contributor

Pull request #47552 was updated. @aloeliger, @cmsbuild, @epalencia can you please check and sign again.

@quinnanm
Copy link
Contributor Author

done!

thanks. Where is the equivalent master PR (for the CMSSW_15_1_X branch?)

here: #47564

@cmsbuild
Copy link
Contributor

Pull request #47552 was updated. @aloeliger, @cmsbuild, @epalencia can you please check and sign again.

@kpedro88
Copy link
Contributor

test parameters:
pull_request = cms-sw/cmsdist#9744

(updating to be consistent between cmssw and cmsdist branches)

@kpedro88
Copy link
Contributor

test parameters:
pull_request = cms-sw/cmsdist#9744

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants