Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AXOL1TL.spec with axol1tl v5 #9741

Open
wants to merge 1 commit into
base: IB/CMSSW_15_1_X/master
Choose a base branch
from

Conversation

quinnanm
Copy link
Contributor

@quinnanm quinnanm commented Mar 11, 2025

Update to most recent model version 5 for new menu

related PR: #9744

tag: https://github.com/cms-hls4ml/AXOL1TL/releases/tag/v5.0.0

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @quinnanm for branch IB/CMSSW_15_1_X/master.

@cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 11, 2025

cms-bot internal usage

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8224fd/44932/summary.html
COMMIT: 43a0895
CMSSW: CMSSW_15_1_X_2025-03-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9741/44932/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

make[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/AXOL1TL/5.0.0-bd308c74c155469628aa2b6174f61b37/AXOL1TL-5.0.0/AXOL1TL_v1'
g++ -O3 -fPIC -std=c++17 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/hls4mlEmulatorExtras/1.1.4-7f1f5ec35d8cc94e9bab71c7ff9456f1/lib64 -lemulator_interface -shared GTADModel_emulator_v3.o GTADModel_v3.o -o GTADModel_v3.so
make[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc12/external/AXOL1TL/5.0.0-bd308c74c155469628aa2b6174f61b37/AXOL1TL-5.0.0/AXOL1TL_v3'
cp: cannot stat 'AXOL1TL_v4/GTADModel_v5.so': No such file or directory
make: *** [Makefile:16: all] Error 1
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.IxSjxI (%build)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+AXOL1TL+5.0.0-bd308c74c155469628aa2b6174f61b37
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.IxSjxI (%build)


@quinnanm
Copy link
Contributor Author

sorry, I updated the release to fix a small typo in the Makefile that lead to the above compile error. it should work now!
(changed 'AXOL1TL_v4/GTADModel_v5.so' to 'AXOL1TL_v5/GTADModel_v5.so')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants