Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx360R Inhibit ZDC digitization in Phase2 scenario #46720

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Phase2-hgx360R Inhibit ZDC digitization in Phase2 scenario #46720

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01215d6
Inhibit ZDC digitization in Phase2 scenario
Nov 18, 2024
525eaac
As suggested by Andrea
Nov 20, 2024
7dc15d3
Modify the comments
Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion SimCalorimetry/HcalSimProducers/python/hcalUnsuppressedDigis_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,10 @@

# remove HE processing for phase 2, completely put in HGCal land
from Configuration.Eras.Modifier_phase2_hgcal_cff import phase2_hgcal
phase2_hgcal.toModify(hcalSimBlock, killHE = cms.bool(True) )
phase2_hgcal.toModify(hcalSimBlock,
doZDCDigi = cms.bool(False),
killHE = cms.bool(True)
Copy link
Contributor

@perrotta perrotta Nov 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
doZDCDigi = cms.bool(False),
killHE = cms.bool(True)
doZDCDigi = False,
killHE = True

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are there, please remove explicit types also from L63 and L74

)

# remove HE processing for phase 2, completely put in HGCal land
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update also this comment, which was just copy-pasted from the previous one but it does not correspond to what actually implemented here

from Configuration.Eras.Modifier_zdcNoDigi_cff import zdcNoDigi
Expand Down