Phase2-hgx360R Inhibit ZDC digitization in Phase2 scenario

[bsunanda]

PR description:

Inhibit ZDC digitization in Phase2 scenario

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46720/42689

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

• SimCalorimetry/HcalSimProducers (simulation)

@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@abdoulline, @mariadalfonso, @rovere, @sameasy this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[abdoulline]

@bsunanda I'm afraid you didn't read my email (neither discussion on Mattermost)...

• you didn't address Andrea's comment about an irrelevant line in the config
• we do need not only inhibit ZDC digitization for phase2, but also fix the hardcoded conditions for it as shown in the branch, as they're initialized independently of the ZDC digitization

For the second bullet - I'll need to submit a separate PR.

[perrotta]

Suggested change

	doZDCDigi = cms.bool(False),
	killHE = cms.bool(True)
	doZDCDigi = False,
	killHE = True

[perrotta]

Since you are there, please remove explicit types also from L63 and L74

[perrotta]

Please update also this comment, which was just copy-pasted from the previous one but it does not correspond to what actually implemented here

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a9714d/42916/summary.html
COMMIT: 01215d6
CMSSW: CMSSW_14_2_X_2024-11-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46720/42916/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 231 lines to the logs
• Reco comparison results: 14829 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3344340
• DQMHistoTests: Total failures: 105740
• DQMHistoTests: Total nulls: 76
• DQMHistoTests: Total successes: 3238504
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: found differences in 4 / 44 workflows

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46720/42725

[cmsbuild]

Pull request #46720 was updated. @civanch, @cmsbuild, @kpedro88, @mdhildreth can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46720/42726

[cmsbuild]

Pull request #46720 was updated. @civanch, @kpedro88, @mdhildreth can you please check and sign again.

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a9714d/42981/summary.html
COMMIT: 7dc15d3
CMSSW: CMSSW_14_2_X_2024-11-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46720/42981/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 6 lines from the logs
• Reco comparison results: 14833 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3483722
• DQMHistoTests: Total failures: 113940
• DQMHistoTests: Total nulls: 76
• DQMHistoTests: Total successes: 3369686
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: found differences in 4 / 44 workflows

[perrotta]

Thank you @bsunanda , this is fine with me

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1