Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_1_X] Add PbPbHighPtJets skim for 2024 PbPb backport #46514

Merged

Conversation

cfmcginn
Copy link
Contributor

PR description:

This PR adds a new skim for high-pT jets (pT > 300, |eta| < 2.4) saving RAW-RECO in PbPb. Should correspond to no greater than 100k events (estimate from 2018 data puts it at ~20k). To be applied to the hadronic physics PDs (i.e. not HIForward/UPCs). This is a backport of existing PR to main, #46499

@mandrenguyen

PR validation:

Tested as part of main PR, appears to create skim as expected for specified cuts. See main PR for details

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport, main PR is here: #46499

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cfmcginn for CMSSW_14_1_X.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@AdrianoDee, @cmsbuild, @kskovpen, @miquork, @sunilUIET can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 25, 2024

cms-bot internal usage

@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2fce56/42399/summary.html
COMMIT: b9e3ee3
CMSSW: CMSSW_14_1_X_2024-10-27-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46514/42399/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3562835
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3562812
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 199 log files, 169 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

urgent

@cfmcginn
Copy link
Contributor Author

Conflict is resolved

@cmsbuild
Copy link
Contributor

Pull request #46514 was updated. @AdrianoDee, @cmsbuild, @DickyChant, @miquork can you please check and sign again.

@AdrianoDee
Copy link
Contributor

please test with #46560

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2fce56/42500/summary.html
COMMIT: edaba07
CMSSW: CMSSW_14_1_X_2024-10-31-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46514/42500/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3565669
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3565649
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 199 log files, 169 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #46560

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7e9ad97 into cms-sw:CMSSW_14_1_X Oct 31, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants