Add PbPbHighPtJets skim for 2024 PbPb #46499

cfmcginn · 2024-10-23T18:39:56Z

PR description:

This PR adds a new skim for high-pT jets (pT > 300, |eta| < 2.4) saving RAW-RECO in PbPb. Should correspond to no greater than 100k events (estimate from 2018 data puts it at ~20k). To be applied to the hadronic physics PDs (i.e. not HIForward/UPCs).

@mandrenguyen

PR validation:

Tested in CMSSW_14_2_X_2024-10-20-0000, compiles and appears to run when tested w/ runTheMatrix.py -l 142.0 -n -e, modifying step 3 to include the newly defined PbPbHighPtJets skim as:

-s RAW2DIGI,L1Reco,RECO,SKIM:PbPbHighPtJets,PAT

The output appears correctly sensitive to specified trigger path and threshold cuts.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 14_1_X. EDIT: Backport is now up here #46514

Updated for eta cut, switched selector Updates to simplify the output content commands

cmsbuild · 2024-10-23T18:40:15Z

cms-bot internal usage

mandrenguyen · 2024-10-23T18:44:59Z

youyingli This is the last PR needed for PbPb data taking this year (well, it's backport). As you suggested let's follow up with @cms-sw/pdmv-l2 how to do test these.

cmsbuild · 2024-10-23T18:45:01Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46499/42350

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Skimming/python/Skims_PbPb_cff.py modified in PR(s): Add UPC monopole skim for 2024 PbPb #46434

cmsbuild · 2024-10-23T18:45:23Z

A new Pull Request was created by @cfmcginn for master.

It involves the following packages:

Configuration/Skimming (pdmv)

@AdrianoDee, @cmsbuild, @kskovpen, @miquork, @sunilUIET can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mandrenguyen · 2024-10-24T15:55:41Z

please test

cmsbuild · 2024-10-24T18:59:55Z

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3655e/42382/summary.html
COMMIT: 3258df0
CMSSW: CMSSW_14_2_X_2024-10-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46499/42382/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 4 lines to the logs
Reco comparison results: 11 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3566343
DQMHistoTests: Total failures: 425
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3565898
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 201 log files, 171 edm output root files, 46 DQM output files
TriggerResults: no differences found

mandrenguyen · 2024-10-24T19:50:02Z

cfmcginn please proceed with a 14_1_X backport

stahlleiton · 2024-10-24T22:04:24Z

Should this skim be also included in the autoSkim file?

youyingli · 2024-10-25T03:59:27Z

Should this skim be also included in the autoSkim file?

Yes, it should be added. However, #46447 also modified this line which could conflict.

cfmcginn · 2024-10-25T08:23:18Z

I will setup the backport. For the autoSkim line, perhaps it makes sense for me to update after #46447 is merged?

mandrenguyen · 2024-10-25T08:39:52Z

I will setup the backport. For the autoSkim line, perhaps it makes sense for me to update after #46447 is merged?

I think it's best to just update everything now, and we handle the merge conflicts as they arise.

cfmcginn · 2024-10-25T08:47:54Z

I will setup the backport. For the autoSkim line, perhaps it makes sense for me to update after #46447 is merged?

I think it's best to just update everything now, and we handle the merge conflicts as they arise.

Understood, will do

mandrenguyen · 2024-10-30T21:22:41Z

+1

smuzaffar · 2024-10-30T21:37:10Z

@cfmcginn , this PR now has conflicts, can you please resolve it?

cfmcginn · 2024-10-30T22:01:47Z

@cfmcginn , this PR now has conflicts, can you please resolve it?

I believe the conflict is resolved

cmsbuild · 2024-10-30T22:05:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46499/42443

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Skimming/python/autoSkim.py modified in PR(s): Update the PbPb skims for 2024 data taking #46447

cmsbuild · 2024-10-30T22:06:15Z

Pull request #46499 was updated. @cmsbuild can you please check and sign again.

mandrenguyen · 2024-10-30T22:15:48Z

+1

cmsbuild · 2024-10-31T01:36:30Z

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3655e/42490/summary.html
COMMIT: b880056
CMSSW: CMSSW_14_2_X_2024-10-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46499/42490/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3655e/42490/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3655e/42490/git-merge-result

DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

2024.0000012024.000001_RunJetMET02024D_10k/step1_dasquery.log
2024.0010012024.001001_RunZeroBias2024D_10k/step1_dasquery.log
2024.1000012024.100001_RunJetMET02024C_10k/step1_dasquery.log

Expand to see more relval errors ...

2024.101001
2024.000001
2024.001001
2024.100001
2024.101001

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 1883 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3569372
DQMHistoTests: Total failures: 225
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3569127
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 201 log files, 171 edm output root files, 46 DQM output files
TriggerResults: no differences found

AdrianoDee · 2024-10-31T05:26:20Z

+pdmv
Failures relates to #46555

AdrianoDee · 2024-10-31T05:27:29Z

please test with #46559

mandrenguyen · 2024-10-31T15:16:31Z

+1

mandrenguyen · 2024-10-31T15:17:37Z

merge
Tests are passed, just comparisons are just slow

cmsbuild · 2024-10-31T15:54:34Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3655e/42494/summary.html
COMMIT: b880056
CMSSW: CMSSW_14_2_X_2024-10-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46499/42494/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@stahlleiton Add UPC monopole skim for 2024 PbPb #46434

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3655e/42494/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3655e/42494/git-merge-result

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3569372
DQMHistoTests: Total failures: 374
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3568978
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 201 log files, 171 edm output root files, 46 DQM output files
TriggerResults: no differences found

Initial commit; need to also mod autoSkim.py + check evtcontent

3258df0

Updated for eta cut, switched selector Updates to simplify the output content commands

cmsbuild added this to the CMSSW_14_2_X milestone Oct 23, 2024

cmsbuild added pending-signatures tests-pending orp-pending pdmv-pending code-checks-pending labels Oct 23, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 23, 2024

cmsbuild mentioned this pull request Oct 23, 2024

Add UPC monopole skim for 2024 PbPb #46434

Merged

cmsbuild added tests-started and removed tests-pending labels Oct 24, 2024

cmsbuild added tests-approved and removed tests-started labels Oct 24, 2024

Updated autoSkim.py for PbPbHighPtJets

bc10da2

cmsbuild added tests-pending and removed tests-approved code-checks-approved labels Oct 25, 2024

cmsbuild added the orp-approved label Oct 30, 2024

Merge branch 'master' into 20241020_PbPbJetSkim

b880056

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Oct 30, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 30, 2024

cmsbuild added tests-started and removed tests-pending labels Oct 30, 2024

cmsbuild added tests-rejected and removed tests-started labels Oct 31, 2024

cmsbuild added requires-external tests-started and removed tests-rejected labels Oct 31, 2024

cmsbuild merged commit 77e87d3 into cms-sw:master Oct 31, 2024
10 of 11 checks passed

cmsbuild added tests-approved and removed tests-started labels Oct 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add PbPbHighPtJets skim for 2024 PbPb #46499

Add PbPbHighPtJets skim for 2024 PbPb #46499

cfmcginn commented Oct 23, 2024 •

edited

Loading

cmsbuild commented Oct 23, 2024 •

edited

Loading

mandrenguyen commented Oct 23, 2024

cmsbuild commented Oct 23, 2024

cmsbuild commented Oct 23, 2024

mandrenguyen commented Oct 24, 2024

cmsbuild commented Oct 24, 2024

mandrenguyen commented Oct 24, 2024

stahlleiton commented Oct 24, 2024

youyingli commented Oct 25, 2024

cfmcginn commented Oct 25, 2024

mandrenguyen commented Oct 25, 2024

cfmcginn commented Oct 25, 2024

mandrenguyen commented Oct 30, 2024

smuzaffar commented Oct 30, 2024

cfmcginn commented Oct 30, 2024

cmsbuild commented Oct 30, 2024

cmsbuild commented Oct 30, 2024

mandrenguyen commented Oct 30, 2024

cmsbuild commented Oct 31, 2024

AdrianoDee commented Oct 31, 2024

AdrianoDee commented Oct 31, 2024

mandrenguyen commented Oct 31, 2024

mandrenguyen commented Oct 31, 2024

cmsbuild commented Oct 31, 2024

Add PbPbHighPtJets skim for 2024 PbPb #46499

Add PbPbHighPtJets skim for 2024 PbPb #46499

Conversation

cfmcginn commented Oct 23, 2024 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Oct 23, 2024 • edited Loading

mandrenguyen commented Oct 23, 2024

cmsbuild commented Oct 23, 2024

cmsbuild commented Oct 23, 2024

mandrenguyen commented Oct 24, 2024

cmsbuild commented Oct 24, 2024

Comparison Summary

mandrenguyen commented Oct 24, 2024

stahlleiton commented Oct 24, 2024

youyingli commented Oct 25, 2024

cfmcginn commented Oct 25, 2024

mandrenguyen commented Oct 25, 2024

cfmcginn commented Oct 25, 2024

mandrenguyen commented Oct 30, 2024

smuzaffar commented Oct 30, 2024

cfmcginn commented Oct 30, 2024

cmsbuild commented Oct 30, 2024

cmsbuild commented Oct 30, 2024

mandrenguyen commented Oct 30, 2024

cmsbuild commented Oct 31, 2024

RelVals-INPUT

Comparison Summary

AdrianoDee commented Oct 31, 2024

AdrianoDee commented Oct 31, 2024

mandrenguyen commented Oct 31, 2024

mandrenguyen commented Oct 31, 2024

cmsbuild commented Oct 31, 2024

Comparison Summary

cfmcginn commented Oct 23, 2024 •

edited

Loading

cmsbuild commented Oct 23, 2024 •

edited

Loading