Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Golden Workflows for 2022 and 2023 Data #45836

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

AdrianoDee
Copy link
Contributor

PR description:

Following the setup introduced in #45055 for 2024 data wfs, this PR proposes to add also the equivalent set of workflows for 2022 and 2023 data. As in the parent PR a smaller set of wfs is added to relval_standard.py just to keep testing the machinery in the IBs, while the higher stats wfs are in relval_data_highstats.py.

PR validation:

E.g. runTheMatrix.py -w data -l 2022.000005, 2023.001005.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 29, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@AdrianoDee, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #45836 was updated. @AdrianoDee, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2024

Pull request #45836 was updated. @AdrianoDee, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again.

@AdrianoDee
Copy link
Contributor Author

test parameters:

  • workflows = 2022.000001,2022.001001,2022.100001,2022.101001,2023.000001,2023.001001,2023.100001,2023.101001

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2024

Pull request #45836 was updated. @AdrianoDee, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again.

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2024

+1

Size: This PR adds an extra 72KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14f195/41212/summary.html
COMMIT: 29dc453
CMSSW: CMSSW_14_2_X_2024-09-01-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45836/41212/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@AdrianoDee
Copy link
Contributor Author

+pdmv

@srimanob
Copy link
Contributor

srimanob commented Sep 2, 2024

Hi @AdrianoDee
Is it by intention that you run 2023 data with GRun in HLT step, e.g. here?

Thx.

@AdrianoDee
Copy link
Contributor Author

Hi @srimanob, yes, this was a trick to continue testing the 2024 menu on 2023 samples until 2024 RelVals were out. Now we can most probably move this to Fake (I imagine, @cms-sw/hlt-l2 ?). But this is valid in general for 2023 data wfs.

@mmusich
Copy link
Contributor

mmusich commented Sep 2, 2024

Now we can most probably move this to Fake (I imagine, @cms-sw/hlt-l2 ?). But this is valid in general for 2023 data wfs.

yes, provided we have workflows that run GRun on 2024 in master, you can move 2023 to Fake2.

@srimanob
Copy link
Contributor

srimanob commented Sep 5, 2024

Hi @AdrianoDee
Do you want to fix, or we let's it go? I am fine in either ways.

@AdrianoDee
Copy link
Contributor Author

Hi @srimanob I'd split it into another cleanup PR.

@srimanob
Copy link
Contributor

srimanob commented Sep 5, 2024

+Upgrade

There will be follow up cleanup PR.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0e150de into cms-sw:master Sep 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants