Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move relval2023 autoHLT key to 2023v12 frozen menu and create relval2024 autoHLT key (currently pointing to GRun) #43357

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 22, 2023

PR description:

This is a follow-up to #43343.
Now that the HLT menu development is moved to 13_3_0, we can point the relval2023 autoHLT key to use the 2023v12 frozen menu.
Concurrently a relval2024 autoHLT key (pointing to the GRun menu) is created and used for the 2024-based relvals.
In order to keep running the GRun menu on real data the 2023 data workflows are altered in order to consume the newly created relval2024 key. This solution is transient until we don't have a proper set of 2024 data to exercise tests on.

PR validation:

cmssw compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43357/37829

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Configuration/HLT (hlt)
  • Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @srimanob, @cmsbuild, @mmusich, @sunilUIET, @miquork, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @slomeo, @silviodonato, @missirol, @Martin-Grunewald this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Nov 22, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-71f926/36013/summary.html
COMMIT: 9d61cbe
CMSSW: CMSSW_14_0_X_2023-11-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43357/36013/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 779 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 197 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3158492
  • DQMHistoTests: Total failures: 5451
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3153018
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -536359.749 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 12434.0,... ): -41173.651 KiB HLT/JME
  • DQMHistoSizes: changed ( 12434.0,... ): -17513.427 KiB HLT/Tracking
  • DQMHistoSizes: changed ( 12434.0,... ): -10390.469 KiB HLT/SiStrip
  • DQMHistoSizes: changed ( 12434.0,... ): -10237.354 KiB HLT/HCAL
  • DQMHistoSizes: changed ( 12434.0,... ): -10124.201 KiB HLT/BTV
  • DQMHistoSizes: changed ( 12434.0,... ): -10043.763 KiB HLT/EXO
  • DQMHistoSizes: changed ( 12434.0,... ): -9232.246 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 12434.0,... ): -9053.111 KiB HLT/Muon
  • DQMHistoSizes: changed ( 12434.0,... ): -8697.605 KiB HLT/Pixel
  • DQMHistoSizes: changed ( 12434.0,... ): -5317.474 KiB HLT/SUSYBSM
  • DQMHistoSizes: changed ( 12434.0 ): ...
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 4 / 48 workflows

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43357/37844

@cmsbuild
Copy link
Contributor

Pull request #43357 was updated. @cmsbuild, @sunilUIET, @srimanob, @Martin-Grunewald, @AdrianoDee, @miquork, @mmusich can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 23, 2023

please test

@cmsbuild
Copy link
Contributor

Pull request #43357 was updated. @mmusich, @AdrianoDee, @cmsbuild, @sunilUIET, @miquork, @Martin-Grunewald, @srimanob can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 28, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-71f926/36113/summary.html
COMMIT: eed3398
CMSSW: CMSSW_14_0_X_2023-11-27-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43357/36113/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 371 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 65 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3359869
  • DQMHistoTests: Total failures: 8703
  • DQMHistoTests: Total nulls: 61
  • DQMHistoTests: Total successes: 3351083
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -765.189 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 12434.0,... ): -196.482 KiB HLT/TAU
  • DQMHistoSizes: changed ( 12434.0,... ): -51.651 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 12434.0,... ): -6.930 KiB HLT/Filters
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 2 / 48 workflows

@mmusich
Copy link
Contributor Author

mmusich commented Nov 29, 2023

+hlt

@AdrianoDee
Copy link
Contributor

+pdmv

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a1f9e78 into cms-sw:master Nov 29, 2023
11 checks passed
@mmusich mmusich deleted the move2024toGRunAnd2023toFake2 branch November 29, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants