Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 14.1.X] Refine RPCDigis Validation histograms #45833

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

jhgoh
Copy link
Contributor

@jhgoh jhgoh commented Aug 29, 2024

PR description:

This is a backport of #45702 to 14.1.X release cycle, which is also a follow-up PR of #45029.

PR validation:

  • runTheMatrix.py -l 12434.0 OK
  • scram b code-checks OK
  • scram b code-format OK

(already tested with the CMSSW_14_1_0_pre6, wf 13034.0, 12434.0 and 29634.0 in the original PR)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport of #45702, which was originally proposed for 14.1.X but it eventually went to 14.2.X cycle.
We'd like to have the same set of validation plots across the releases in the further relval campaigns.

@mileva @mrcthiel

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Aug 29, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 29, 2024

A new Pull Request was created by @jhgoh for CMSSW_14_1_X.

It involves the following packages:

  • Validation/MuonRPCDigis (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@JanFSchulte, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 29, 2024

cms-bot internal usage

@tjavaid
Copy link

tjavaid commented Aug 30, 2024

backport of #45702

@tjavaid
Copy link

tjavaid commented Aug 30, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a7ff19/41196/summary.html
COMMIT: 192acaa
CMSSW: CMSSW_14_1_X_2024-08-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45833/41196/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3328126
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3328098
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -32.528 KiB( 43 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): -1.712 KiB RPCDigisV/RPCDigis
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Sep 5, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 08ee6fc into cms-sw:CMSSW_14_1_X Sep 9, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants