Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine RPCDigis Validation histograms #45702

Merged
merged 5 commits into from
Aug 29, 2024
Merged

Conversation

jhgoh
Copy link
Contributor

@jhgoh jhgoh commented Aug 14, 2024

PR description:

This PR is a follow-up PR of the previous one #45029.
In this PR, we want to refine the RPCDigis validation plots.

There was a report in the RPC-DPG working meeting 14 Aug 2024: link to the slide

The proposed changes are

  • Extend x-axis of digi-simhit residual plot for the Ring1, avoid too many underflows/overflows
  • Set default drawing option of 2D histograms ("colz")
  • Use era-modifiers to book timing plots only for Phase2 scenario

PR validation:

Performed tests on CMSSW_14_1_0_pre6 release

  • runTheMatrix.py -l 13034.0 -> OK
    • Also checked the workflow number 12434.0 and 29634.0 with 1,000 events and works fine.
  • code-checks OK
  • code-format OK

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

We want to have backport to the currently active release cycles

  • 14_0_X
  • 14_1_X

Possible watchers: @mileva @mrcthiel

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 14, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jhgoh for master.

It involves the following packages:

  • Validation/MuonRPCDigis (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@JanFSchulte, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@tjavaid
Copy link

tjavaid commented Aug 19, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-410307/41008/summary.html
COMMIT: 192acaa
CMSSW: CMSSW_14_1_X_2024-08-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45702/41008/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 74 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3422434
  • DQMHistoTests: Total failures: 4592
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3417820
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -32.528 KiB( 44 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): -1.712 KiB RPCDigisV/RPCDigis
  • Checked 196 log files, 165 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Aug 27, 2024
@tjavaid
Copy link

tjavaid commented Aug 29, 2024

@jhgoh , just to confirm the existing time plots are now made hidden with this PR from switch introduced for phase-II scenario, right ?

@cmsbuild cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Aug 29, 2024
@jhgoh
Copy link
Contributor Author

jhgoh commented Aug 29, 2024

@jhgoh , just to confirm the existing time plots are now made hidden with this PR from switch introduced for phase-II scenario, right ?

Yes, the timing plots will be hidden in Run3, because they are valid only after the phase-II upgrade.

@tjavaid
Copy link

tjavaid commented Aug 29, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 50f39de into cms-sw:master Aug 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants