Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: initialization of genJetMatch token in appropriate place [14_1_X] #45815

Merged

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Aug 27, 2024

PR description:

As title says: this PR moves initialization of the genJetMatchToken to a correct place which fixes a bug.
This bug have not manifested until now as gen-matching is not used in central workflows.

PR validation:

Validated in a custom workflow with and without enabling gen-matching.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #45802.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 27, 2024

A new Pull Request was created by @mbluj for CMSSW_14_1_X.

It involves the following packages:

  • PhysicsTools/PatAlgos (xpog, reconstruction)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen, @vlimant can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Senphy, @ahinzmann, @andrzejnovak, @azotz, @castaned, @demuller, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jdamgov, @jdolen, @mariadalfonso, @mbluj, @mmarionncern, @nhanvtran, @rappoccio, @schoef, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 27, 2024

cms-bot internal usage

@hqucms
Copy link
Contributor

hqucms commented Aug 27, 2024

enable nano

@hqucms
Copy link
Contributor

hqucms commented Aug 27, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a6576/41163/summary.html
COMMIT: 364fe07
CMSSW: CMSSW_14_1_X_2024-08-27-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45815/41163/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3328202
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3328176
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 20 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 21
  • DQMHistoTests: Total histograms compared: 54921
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 54921
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
  • Checked 102 log files, 58 edm output root files, 21 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001 2.788 2.788 0.000 ( +0.0% ) 3.24 3.28 -1.3% 6.049 6.673
2500.002 2.901 2.901 0.000 ( +0.0% ) 2.87 2.92 -1.9% 6.398 7.029
2500.003 2.848 2.848 0.000 ( +0.0% ) 3.01 3.03 -0.6% 6.371 6.993
2500.011 1.450 1.450 0.000 ( +0.0% ) 5.57 5.54 +0.6% 2.130 2.403
2500.012 1.909 1.909 0.000 ( +0.0% ) 3.12 3.09 +1.1% 2.171 2.594
2500.013 1.765 1.765 0.000 ( +0.0% ) 4.45 4.43 +0.6% 2.144 2.501
2500.021 0.022 0.022 0.000 ( +0.0% ) 0.92 0.95 -2.4% 2.113 2.375
2500.022 0.022 0.022 0.000 ( +0.0% ) 0.88 0.92 -4.5% 2.113 2.370
2500.023 0.022 0.022 0.000 ( +0.0% ) 0.89 0.91 -2.7% 1.956 2.239
2500.024 0.022 0.022 0.000 ( +0.0% ) 0.66 0.68 -3.1% 2.218 2.464
2500.031 0.035 0.035 0.000 ( +0.0% ) 0.83 0.85 -2.0% 2.141 2.427
2500.032 0.036 0.036 0.000 ( +0.0% ) 0.84 0.88 -4.0% 2.077 2.403
2500.033 0.037 0.037 0.000 ( +0.0% ) 0.75 0.72 +3.9% 2.165 2.483
2500.034 0.036 0.036 0.000 ( +0.0% ) 0.76 0.80 -4.0% 2.153 2.460
2500.101 2.646 2.646 0.000 ( +0.0% ) 8.47 8.47 -0.0% 6.336 6.939
2500.111 1.330 1.330 0.000 ( +0.0% ) 18.66 18.35 +1.7% 2.058 2.213
2500.112 1.735 1.735 0.000 ( +0.0% ) 14.69 14.22 +3.3% 2.306 2.304
2500.131 5.194 5.194 0.000 ( +0.0% ) 14.89 14.95 -0.4% 1.491 1.552
2500.201 2.478 2.478 0.000 ( +0.0% ) 7.28 7.38 -1.3% 5.595 6.216
2500.211 1.592 1.592 0.000 ( +0.0% ) 17.21 16.26 +5.8% 2.289 2.289
2500.212 2.033 2.033 0.000 ( +0.0% ) 13.51 13.22 +2.2% 2.374 2.389
2500.221 2.006 2.006 0.000 ( +0.0% ) 7.24 7.44 -2.8% 2.427 2.437
2500.222 3.072 3.072 0.000 ( +0.0% ) 7.27 7.22 +0.7% 2.508 2.523
2500.223 8.888 8.888 0.000 ( +0.0% ) 2.67 2.68 -0.6% 2.140 2.541
2500.224 5.515 5.515 0.000 ( +0.0% ) 1.07 1.05 +1.3% 2.435 2.576
2500.225 5.533 5.533 0.000 ( +0.0% ) 0.98 0.98 +0.7% 2.502 2.606
2500.226 2.973 2.973 0.000 ( +0.0% ) 7.16 7.23 -1.0% 2.508 2.522
2500.227 8.972 8.972 0.000 ( +0.0% ) 9.75 9.62 +1.4% 1.492 1.494
2500.231 1.407 1.407 0.000 ( +0.0% ) 13.56 12.69 +6.8% 2.193 2.196
2500.232 2.145 2.145 0.000 ( +0.0% ) 13.47 12.73 +5.8% 2.283 2.288
2500.233 4.670 4.670 0.000 ( +0.0% ) 4.73 4.65 +1.5% 2.307 2.307
2500.234 3.307 3.307 0.000 ( +0.0% ) 1.48 1.42 +3.9% 2.322 2.327
2500.235 3.317 3.317 0.000 ( +0.0% ) 1.37 1.35 +1.0% 2.107 2.345
2500.236 2.085 2.085 0.000 ( +0.0% ) 13.32 12.85 +3.7% 2.278 2.279
2500.237 7.977 7.977 0.000 ( +0.0% ) 14.31 14.14 +1.2% 1.576 1.572
2500.241 9.405 9.405 0.000 ( +0.0% ) 3.72 3.55 +4.6% 1.964 1.959
2500.242 10.331 10.331 0.000 ( +0.0% ) 0.83 0.83 +0.1% 1.724 1.724
2500.243 2.712 2.712 0.000 ( +0.0% ) 5.85 6.66 -12.1% 1.062 1.059
2500.244 485.976 485.976 0.000 ( +0.0% ) 0.53 0.53 +0.6% 1.671 1.668
2500.245 823.224 823.224 0.000 ( +0.0% ) 0.72 0.70 +2.6% 1.659 1.666
2500.901 1.749 1.749 0.000 ( +0.0% ) 20.11 20.26 -0.7% 1.833 1.830
2500.902 1.598 1.598 0.000 ( +0.0% ) 18.81 20.67 -9.0% 1.417 1.757
2500.911 13.931 13.931 0.000 ( +0.0% ) 2.66 2.83 -6.2% 1.075 1.079
2500.912 0.171 0.310 -0.140 ( -45.0% ) 1.08 1.33 -18.5% 0.966 0.970
2500.913 0.110 0.110 0.000 ( +0.0% ) 1.21 1.12 +7.3% 0.966 0.974

@jfernan2
Copy link
Contributor

+1

@hqucms
Copy link
Contributor

hqucms commented Aug 27, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

backport of #45802

@mandrenguyen
Copy link
Contributor

type jetmet

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f128481 into cms-sw:CMSSW_14_1_X Aug 31, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants