Bug fix: initialization of genJetMatch token in appropriate place

[mbluj]

PR description:

As title says: this PR moves initialization of the genJetMatchToken to a correct place which fixes a bug.
This bug have not manifested until now as gen-matching is not used in central workflows.

PR validation:

Validated in a custom workflow with and without enabling gen-matching.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This probably should be backported to 14_0 series although the gen-matching is disabled in central workflows.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45802/41541

[cmsbuild]

A new Pull Request was created by @mbluj for master.

It involves the following packages:

• PhysicsTools/PatAlgos (xpog, reconstruction)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen, @vlimant can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Senphy, @ahinzmann, @andrzejnovak, @azotz, @castaned, @demuller, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jdamgov, @jdolen, @mariadalfonso, @mbluj, @mmarionncern, @nhanvtran, @rappoccio, @schoef, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[hqucms]

enable nano

[hqucms]

please test

[cmsbuild]

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9669a7/41146/summary.html
COMMIT: 364fe07
CMSSW: CMSSW_14_1_X_2024-08-26-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45802/41146/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3328202
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3328182
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 191 log files, 161 edm output root files, 44 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 21
• DQMHistoTests: Total histograms compared: 54921
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 54921
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
• Checked 102 log files, 58 edm output root files, 21 DQM output files
• TriggerResults: no differences found

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.001	2.788	2.788	0.000 ( +0.0% )	3.32	3.30	+0.5%	6.674	6.029
2500.002	2.901	2.901	0.000 ( +0.0% )	2.95	2.96	-0.1%	7.023	6.406
2500.003	2.848	2.848	0.000 ( +0.0% )	3.07	3.07	+0.1%	6.995	6.354
2500.011	1.450	1.450	0.000 ( +0.0% )	5.70	5.72	-0.5%	2.405	2.400
2500.012	1.909	1.909	0.000 ( +0.0% )	3.12	3.14	-0.7%	2.592	2.592
2500.013	1.765	1.765	0.000 ( +0.0% )	4.53	4.54	-0.2%	2.507	2.497
2500.021	0.022	0.022	0.000 ( +0.0% )	0.98	0.97	+1.1%	2.378	2.374
2500.022	0.022	0.022	0.000 ( +0.0% )	0.93	0.93	-0.5%	2.372	2.371
2500.023	0.022	0.022	0.000 ( +0.0% )	0.93	0.92	+1.5%	2.240	2.239
2500.024	0.022	0.022	0.000 ( +0.0% )	0.71	0.71	-0.4%	2.463	2.456
2500.031	0.035	0.035	0.000 ( +0.0% )	0.87	0.88	-1.7%	2.438	2.443
2500.032	0.036	0.036	0.000 ( +0.0% )	0.90	0.90	+0.0%	2.409	2.404
2500.033	0.037	0.037	0.000 ( +0.0% )	0.80	0.78	+2.2%	2.481	2.481
2500.034	0.036	0.036	0.000 ( +0.0% )	0.81	0.82	-0.2%	2.464	2.456
2500.101	2.646	2.646	0.000 ( +0.0% )	8.78	8.80	-0.1%	6.937	6.267
2500.111	1.330	1.330	0.000 ( +0.0% )	18.89	19.63	-3.8%	2.214	2.213
2500.112	1.735	1.735	0.000 ( +0.0% )	14.49	14.73	-1.6%	2.297	2.172
2500.131	5.194	5.194	0.000 ( +0.0% )	15.55	15.68	-0.8%	1.550	1.545
2500.201	2.478	2.478	0.000 ( +0.0% )	7.63	7.49	+2.0%	6.220	5.588
2500.211	1.592	1.592	0.000 ( +0.0% )	17.34	17.30	+0.2%	2.290	2.132
2500.212	2.033	2.033	0.000 ( +0.0% )	13.93	13.81	+0.9%	2.387	2.183
2500.221	2.006	2.006	0.000 ( +0.0% )	7.66	7.70	-0.5%	2.437	2.434
2500.222	3.072	3.072	0.000 ( +0.0% )	7.38	7.54	-2.2%	2.526	2.518
2500.223	8.888	8.888	0.000 ( +0.0% )	2.77	2.77	+0.2%	2.548	2.534
2500.224	5.515	5.515	0.000 ( +0.0% )	1.10	1.10	+0.6%	2.575	2.256
2500.225	5.533	5.533	0.000 ( +0.0% )	1.01	1.03	-1.8%	2.603	2.263
2500.226	2.973	2.973	0.000 ( +0.0% )	7.49	7.36	+1.8%	2.515	2.326
2500.227	8.972	8.972	0.000 ( +0.0% )	10.01	10.11	-1.0%	1.492	1.491
2500.231	1.407	1.407	0.000 ( +0.0% )	13.92	13.40	+3.9%	2.194	1.936
2500.232	2.145	2.145	0.000 ( +0.0% )	13.91	13.38	+3.9%	2.287	2.051
2500.233	4.670	4.670	0.000 ( +0.0% )	4.84	4.81	+0.7%	2.296	1.813
2500.234	3.307	3.307	0.000 ( +0.0% )	1.51	1.47	+2.9%	2.322	1.843
2500.235	3.317	3.317	0.000 ( +0.0% )	1.39	1.39	-0.5%	2.352	1.535
2500.236	2.085	2.085	0.000 ( +0.0% )	13.97	13.80	+1.2%	2.280	2.072
2500.237	7.977	7.977	0.000 ( +0.0% )	14.46	14.43	+0.2%	1.580	1.440
2500.241	9.405	9.405	0.000 ( +0.0% )	3.77	3.63	+4.0%	1.959	1.793
2500.242	10.331	10.331	0.000 ( +0.0% )	0.87	0.88	-0.1%	1.725	1.728
2500.243	2.712	2.712	0.000 ( +0.0% )	3.04	7.66	-60.3%	1.061	1.059
2500.244	485.976	485.976	0.000 ( +0.0% )	0.55	0.54	+1.4%	1.671	1.671
2500.245	823.224	823.224	0.000 ( +0.0% )	0.74	0.74	-0.9%	1.663	1.656
2500.901	1.749	1.749	0.000 ( +0.0% )	21.32	21.31	+0.1%	1.831	1.832
2500.902	1.598	1.598	0.000 ( +0.0% )	21.96	20.92	+5.0%	1.762	1.370
2500.911	13.931	13.931	0.000 ( +0.0% )	2.74	3.03	-9.7%	1.078	1.080
2500.912	0.310	0.171	0.140 ( +81.9% )	1.53	1.37	+11.9%	0.969	0.971
2500.913	0.110	0.110	0.000 ( +0.0% )	1.12	1.21	-6.9%	0.971	0.965

[jfernan2]

+1

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

[hqucms]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mbluj]

Please confirm that it should be backported to 14_1 and 14_0.

[hqucms]

Please confirm that it should be backported to 14_1 and 14_0.

Yes please make the backport. Thank you!

[mandrenguyen]

type bug-fix, jetmet

[mandrenguyen]

+1