Phase2-hgx359V Modify the testing code in HGCalCommonData & GeometryHGCal in view of changes made in the Configuration/Geometry area for Phase2 scenarios

[bsunanda]

PR description:

Modify the testing code in HGCalCommonData & GeometryHGCal because of changes made in the Configuration/Geometry area for Phase 2 scenarios. Backport of PRs #45787, #45788, #45789

PR validation:

Tested the scripts for V16, V17, V18 versions

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport #45787 #45788 #45789

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_14_1_X.

It involves the following packages:

• Geometry/HGCalCommonData (upgrade, geometry)
• Geometry/HGCalGeometry (upgrade, geometry)

@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@fabiocos, @martinamalberti this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Phase2-hgx359XX Modify Three test scripts to test if the bug-fix for HGCalGeometry Works #45787

[cmsbuild]

cms-bot internal usage

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff4653/41156/summary.html
COMMIT: abc9d59
CMSSW: CMSSW_14_1_X_2024-08-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45811/41156/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3328202
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3328170
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 191 log files, 161 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[civanch]

+1

I would include this clean-up into 14_1_X - these tests may be used in this release in future for Phase-2 for a long time and they does not affect Run3

[bsunanda]

@srimanob Please approve this PR

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

backport of #45787
#45788, #45789

[mandrenguyen]

+1

[mandrenguyen]

type hgcal