Phase2-hgx359XX Modify Three test scripts to test if the bug-fix for HGCalGeometry Works

[bsunanda]

PR description:

Revert the false flag in the appropriate place in HGCalGeometry and has been tested for V17 geometry. Thanks to Andrea Bocci and the HGCal Reco team.

After making this PR, I see there is already PR #45782 which has made the same change in the HGCalGeometry code. So I am removing the fix in this code, but the test codes can remain

PR validation:

Tested using the cfg files in Geometry/HGCalGeometry/test/python

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to CMSSW_18_1_X

[cmsbuild]

cms-bot internal usage

[bsunanda]

Type BugFix

[bsunanda]

Type Urgent

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45787/41517

• There are other open Pull requests which might conflict with changes you have proposed:
  • File Geometry/HGCalGeometry/src/HGCalGeometry.cc modified in PR(s): Fix HGCAL Geometry - Revert norot back to False in locateCell()  #45782

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

• Geometry/HGCalGeometry (upgrade, geometry)

@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@fabiocos, @martinamalberti this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45787/41518

[cmsbuild]

Pull request #45787 was updated. @Dr15Jones, @bsunanda, @civanch, @cmsbuild, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8fab8a/41108/summary.html
COMMIT: bcd83aa
CMSSW: CMSSW_14_1_X_2024-08-23-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45787/41108/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

• 2024.00212024.0021_RunEGamma02024B_1M/step1_dasquery.log
• 2024.4110052024.411005_RunParkingSingleMuon02024F_50k/step1_dasquery.log
• 2024.011052024.01105_RunParkingSingleMuon02024B_500k/step1_dasquery.log

Expand to see more relval errors ...

• 2024.0111
• 2024.2041
• 2024.4111
• 2024.411005
• 2024.0021
• 2024.01105
• 2024.0111
• 2024.2041
• 2024.4111

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 108 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3328202
• DQMHistoTests: Total failures: 2852
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3325330
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 191 log files, 161 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8fab8a/41142/summary.html
COMMIT: bcd83aa
CMSSW: CMSSW_14_1_X_2024-08-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45787/41142/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 5 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3328202
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3328182
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 191 log files, 161 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[bsunanda]

@srimanob Please approve this PR

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

[rovere]

@bsunanda please change the name/title of the PR, squash the commits and reword them as well.

[bsunanda]

@srimanob Please approve this PR

[bsunanda]

@srimanob Please approve this PR

[srimanob]

+Upgrade

I think PR description should be updated too as the "Revert the false flag.." part is not for this PR anymore.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1