Add new configuration options to CloseByParticleGun (backport)

[OzAmram]

Backport of #45515 and older #44008 to 14_0_X release cycle

Functionality needed for upcoming MC production that we do not wish to delay for 14_1_0 release

Description from #45515

This PR adds new functionality to the CloseByParticleGun, specifically the ability to logarithmically space the energy distribution and to specify the particle location based on R and eta. These developments are done in support of upcoming sample generation of HGCal simulations for ML4Sim R&D

Also promoted previous LogErrors related to inconsistencies of the configuration parameters into exceptions

@kpedro88

[cmsbuild]

A new Pull Request was created by @OzAmram for CMSSW_14_0_X.

It involves the following packages:

• IOMC/ParticleGuns (generators)

@bbilin, @cmsbuild, @lviliani, @menglu21, @mkirsano can you please review it and eventually sign? Thanks.
@fabiocos, @grzanka this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[kpedro88]

please test

[cmsbuild]

-1

Failed Tests: RelVals
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-868197/40697/summary.html
COMMIT: 938b266
CMSSW: CMSSW_14_0_X_2024-07-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45601/40697/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 24896.0

----- Begin Fatal Exception 31-Jul-2024 05:22:09 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=CloseByParticleGunProducer label='generator'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'EnMax'
 'EnMin'
 'MaxEnSpread'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

• 24900.0

----- Begin Fatal Exception 31-Jul-2024 05:22:19 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=CloseByParticleGunProducer label='generator'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'EnMax'
 'EnMin'
 'MaxEnSpread'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

[cmsbuild]

Pull request #45601 was updated. @bbilin, @cmsbuild, @lviliani, @menglu21, @mkirsano can you please check and sign again.

[OzAmram]

Sorry forgot to update the configuration of matrix commands in in the first commit

[kpedro88]

please test

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-868197/40706/summary.html
COMMIT: c238fb8
CMSSW: CMSSW_14_0_X_2024-07-31-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45601/40706/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 27 lines from the logs
• Reco comparison results: 47 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3343220
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3343194
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[kpedro88]

@cms-sw/generators-l2 please check

[bbilin]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1