Add new configuration options to CloseByParticleGun

[OzAmram]

This PR adds new functionality to the CloseByParticleGun, specifically the ability to logarithmically space the energy distribution and to specify the particle location based on R and eta. These developments are done in support of upcoming sample generation of HGCal simulations for ML4Sim R&D

Also promoted previous LogErrors related to inconsistencies of the configuration parameters into exceptions

@kpedro88

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45515/40983

[cmsbuild]

A new Pull Request was created by @OzAmram for master.

It involves the following packages:

• IOMC/ParticleGuns (generators)

@bbilin, @cmsbuild, @lviliani, @menglu21, @mkirsano can you please review it and eventually sign? Thanks.
@fabiocos, @grzanka this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

please test

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c3ea2/40521/summary.html
COMMIT: 7eae51d
CMSSW: CMSSW_14_1_X_2024-07-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45515/40521/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345208
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3345186
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[kpedro88]

@cms-sw/generators-l2 please check and sign

[kpedro88]

ping @cms-sw/generators-l2. this PR is needed for an upcoming MC production request.

[bbilin]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1